[
https://issues.apache.org/jira/browse/HIVE-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800030#action_12800030
]
Zheng Shao commented on HIVE-983:
---------------------------------
Code looks good, but please follow Java code convention:
http://java.sun.com/docs/codeconv/CodeConventions.pdf
Page 17 top line.
{code}
Note: if statements always use braces {}. Avoid the following error-prone form:
if (condition) //AVOID! THIS OMITS THE BRACES {}!
statement;
{code}
> Function from_unixtime only takes Int. Override to support Long
> ----------------------------------------------------------------
>
> Key: HIVE-983
> URL: https://issues.apache.org/jira/browse/HIVE-983
> Project: Hadoop Hive
> Issue Type: Improvement
> Reporter: Matt Pestritto
> Assignee: Ning Zhang
> Priority: Minor
> Attachments: HIVE-983.patch
>
>
> UDFFromUnixTime.java only supports int. We have dates that are future dated
> so they fail when it tries to parse. Can there be additional support for
> LongWritable input parameter ?
> We also have dates stored with milliseconds which blows up the integer
> limitation. Long support will be helpful.
> FAILED: Error in semantic analysis: line 1:7 Function Argument Type Mismatch
> from_unixtime: Looking for UDF "from_unixtime" with parameters [class
> org.apache.hadoop.io.LongWritable
> ]
> 09/12/14 11:42:10 ERROR ql.Driver: FAILED: Error in semantic analysis: line
> 1:7 Function Argument Type Mismatch from_unixtime: Looking for UDF
> "from_unixtime" with parameters [clas
> s org.apache.hadoop.io.LongWritable]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
