[ 
https://issues.apache.org/jira/browse/HIVE-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835898#action_12835898
 ] 

Namit Jain commented on HIVE-1134:
----------------------------------

Few minor comments:

1. CheckStyle - lot of code needs { }

For eg:

 if (!checkBucketNumberAgainstBigTable(aliasToBucketNumberMapping,      
        bucketNumberInPart))     
   return null;

2. Modify existing tests to run the test without the hint and then compare the 
results.

3. Cleanup GenMapredUtils.setupBucketMapJoinInfo

> bucketing mapjoin where the big table contains more than 1 big partition
> ------------------------------------------------------------------------
>
>                 Key: HIVE-1134
>                 URL: https://issues.apache.org/jira/browse/HIVE-1134
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: He Yongqiang
>             Fix For: 0.6.0
>
>         Attachments: hive-1134-2010-02-17.patch, hive-1134-2010-02-18.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to