[
https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arvind Prabhakar updated HIVE-1198:
-----------------------------------
Status: Patch Available (was: Open)
This patch address this issue as follows:
1. The .checkstyle file's match pattern has been changed. This is done to
exclude top-level ant directory from being included in the checkstyle
application path. Since this is not a valid source directory, it causes
checkstyle to report errors for all matching files within it.
2. The build file - build.xml has been modified to exclude {{ant}} directory
from processing under the checkstyle target for the same reason as above.
3. The {{eclipse-templates/.project}} file has been modified to include the
{{CheckstyleBuilder}} and {{CheckstyleNature}}. This would automatically enable
checkstyle when the project is imported in Eclipse. I tested out the scenario
of importing the project in Eclipse without having the checkstyle plugin
installed - it did not seem to cause any noticeable problem.
4. The section on {{Developing Hive using Eclipse}} in the README.txt has been
updated to state that the user must install Checkstyle plugin in eclipse if not
already present before importing the project.
> When checkstyle is activated for Hive in Eclipse environment, it shows all
> checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin
> 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an
> overwhelming number of errors to show up (3000+) which masks real errors that
> might be there. Since all the checkstyle violations are not going to be fixed
> in one shot, it is desirable to lower the severity of checkstyle violations
> to warnings so that the plugin can be kept enabled. This will encourage
> developers to spot checkstyle violations in the files they touch and
> potentially fix them as they go along, along with pointing out violations as
> they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
