[ https://issues.apache.org/jira/browse/HIVE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871982#action_12871982 ]
Ning Zhang commented on HIVE-1359: ---------------------------------- #1: will do that in a separate xml file. #2: hive-default.xml should be the default for all tests. hive-site.xml is an overlay on top of that and it can only contains special Hive configs related to shims/minimr. I'm thinking to define a hive-site-<shims>-<minimr/local>.xml for each combination if they require special hive parameters. which file should be used should be determined by the -Dhaoop.version and -Dhadoop.mode values. #3: yes. if the user specifies the hadoop configuration using -Dhadoop.* and not -Dhive.conf we will use the default one as mentioned in #2. The -Dhive.conf gives the user an additional flexibility to test non-default hive settings easily. #4 I agree we should be add minimr test as part of the default testing. Since HIVE-117 already tracking that, I'll leave it out of this jira, which should be easier once this patch is checked in. > Unit test should be shim-aware > ------------------------------ > > Key: HIVE-1359 > URL: https://issues.apache.org/jira/browse/HIVE-1359 > Project: Hadoop Hive > Issue Type: New Feature > Reporter: Ning Zhang > Assignee: Ning Zhang > Attachments: unit_tests.txt > > > Some features in Hive only works for certain Hadoop versions through shim. > However the unit test structure is not shim-aware in that there is only one > set of queries and expected outputs for all Hadoop versions. This may not be > sufficient when we will have different output for different Hadoop versions. > One example is CombineHiveInputFormat wich is only available from Hadoop > 0.20. The plan using CombineHiveInputFormat and HiveInputFormat may be > different. Another example is archival partitions (HAR) which is also only > available from 0.20. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.