[ 
https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872296#action_12872296
 ] 

Arvind Prabhakar commented on HIVE-1198:
----------------------------------------

Ning - I have attached an updated patch - (hive-1198-2.patch). The key 
difference in this patch is that it does not activate checkstyle by default. 
When you import the hive project and you wish to activate checkstyle, you will 
have to right click on the project  and select Checkstyle > Activate Checkstyle 
from the context menu.

So in case checkstyle is causing problems on your workbench, you can choose to 
not activate it. The steps to activate checkstyle plugin in eclipse are also 
documented in the README.txt file, right below the section on setting up 
Eclipse. 

Can you give this patch a try and see if it resolves the problem you were 
facing?


> When checkstyle is activated for Hive in Eclipse environment, it shows all 
> checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-1198
>                 URL: https://issues.apache.org/jira/browse/HIVE-1198
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Build Infrastructure
>         Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 
> 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>            Priority: Minor
>         Attachments: HIVE-1198-1.patch, HIVE-1198-2.patch, HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an 
> overwhelming number of errors to show up (3000+) which masks real errors that 
> might be there. Since all the checkstyle violations are not going to be fixed 
> in one shot, it is desirable to lower the severity of checkstyle violations 
> to warnings so that the plugin can be kept enabled. This will encourage 
> developers to spot checkstyle violations in the files they touch and 
> potentially fix them as they go along, along with pointing out violations as 
> they code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to