> On 2010-06-14 15:26:25, Carl Steinbach wrote: > > Looks good overall. > > > > A couple suggestions: > > * Stash this stuff under docs/ instead of creating another top level > > directory (xdocs/) > > * Manage the jdom dependency with Ivy. > > * Limit the initial import to the convents of the Hive Language Manual. I > > think some things should actually stay on the wiki, but the language manual > > is definitely one of those things that we want to have in VCS.
* Running the docs target causes a 'velocity.log' file to appear in the source root directory. This should probably be redirected to build/dist/docs. See http://velocity.apache.org/engine/releases/velocity-1.4/developer-guide.html#Velocity Configuration Keys and Values - Carl ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/178/#review217 ----------------------------------------------------------- On 2010-06-14 14:43:29, Carl Steinbach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/178/ > ----------------------------------------------------------- > > (Updated 2010-06-14 14:43:29) > > > Review request for Hive Developers. > > > Summary > ------- > > Submitted on behalf of Ed Capriolo. > > > This addresses bug hive-1135. > http://issues.apache.org/jira/browse/hive-1135 > > > Diffs > ----- > > trunk/build.xml 953531 > trunk/hwi/web/set_processor.jsp 953531 > trunk/xdocs/docs/glossary.xml PRE-CREATION > trunk/xdocs/docs/index.xml PRE-CREATION > trunk/xdocs/docs/language_manual/data-manipulation-statements.xml > PRE-CREATION > trunk/xdocs/docs/language_manual/working_with_bucketed_tables.xml > PRE-CREATION > trunk/xdocs/docs/user/hwi.xml PRE-CREATION > trunk/xdocs/site.css PRE-CREATION > trunk/xdocs/stylesheets/project.xml PRE-CREATION > trunk/xdocs/stylesheets/site.vsl PRE-CREATION > trunk/xdocs/velocity.properties PRE-CREATION > > Diff: http://review.hbase.org/r/178/diff > > > Testing > ------- > > > Thanks, > > Carl > >
