[ 
https://issues.apache.org/jira/browse/HIVE-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879943#action_12879943
 ] 

John Sichi commented on HIVE-1387:
----------------------------------

Two refinements:

1) Rather than subclassing GenericUDAFHistogramNumeric directly, I would 
recommend factoring out commonality (either into an abstract base, or into a 
separate reusable class representing the histogram component).

2) For the new percentile generic UDAF, use the defaults you describe, but 
allow the user to override (i.e. to be able to choose approx even for integers, 
or to be able to choose exact for floating point).  And for approx, provide 
override in addition to your default on the number of bins.


> Make PERCENTILE work with double data type
> ------------------------------------------
>
>                 Key: HIVE-1387
>                 URL: https://issues.apache.org/jira/browse/HIVE-1387
>             Project: Hadoop Hive
>          Issue Type: Improvement
>            Reporter: Vaibhav Aggarwal
>            Assignee: Mayank Lahiri
>         Attachments: patch-1387-1.patch
>
>
> The PERCENTILE UDAF does not work with double datatype.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to