[ https://issues.apache.org/jira/browse/HIVE-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883297#action_12883297 ]
John Sichi commented on HIVE-1229: ---------------------------------- Hey Basab, See my review comments above. They are all minor except one: hbase_joins.q is currently failing: ant test -Dtestcase=TestHBaseCliDriver -Dqfile=hbase_joins.q I think it might have to do with the fact that you got rid of the column mapping from the splits; I think we need to keep this because in the presence of multiple tables, the parameter in the job conf changes. But I didn't look into it carefully. Thanks for cleaning up so much code in this patch; it is a big improvement overall. > replace dependencies on HBase deprecated API > -------------------------------------------- > > Key: HIVE-1229 > URL: https://issues.apache.org/jira/browse/HIVE-1229 > Project: Hadoop Hive > Issue Type: Improvement > Components: HBase Handler > Affects Versions: 0.6.0 > Reporter: John Sichi > Assignee: Basab Maulik > Attachments: HIVE-1229.1.patch, HIVE-1229.2.patch > > > Some of these dependencies are on the old Hadoop mapred packages; others are > HBase-specific. The former have to wait until the rest of Hive moves over to > the new Hadoop mapreduce package, but the HBase-specific ones don't have to > wait. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.