[
https://issues.apache.org/jira/browse/HIVE-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886608#action_12886608
]
He Yongqiang commented on HIVE-1305:
------------------------------------
Overall looks good to me.
minor comments:
1. in GroupByOp's flush,
countAfterReport = 0; should put in the beginning of the function?
2. in AbstractMapjoin
heartbeatInterval = HiveConf.getIntVar(hconf,
HiveConf.ConfVars.HIVESENDHEARTBEAT);
is not needed? because the parent common join op already has that.
> add progress in join and groupby
> --------------------------------
>
> Key: HIVE-1305
> URL: https://issues.apache.org/jira/browse/HIVE-1305
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Siying Dong
> Attachments: hive.1305.1.patch, hive.1305.2.patch
>
>
> The operators join and groupby can consume a lot of rows before producing any
> output.
> All operators which do not have a output for every input should report
> progress periodically.
> Currently, it is only being done for ScriptOperator and FilterOperator.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
