[ 
https://issues.apache.org/jira/browse/HIVE-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886794#action_12886794
 ] 

Zheng Shao commented on HIVE-287:
---------------------------------

The plan looks good to me.

Just one comment: I think we should change the comment/class name for 
GenericUDAFResolver2.  Let's explicitly say GenericUDAFResolver2 is for UDAFs 
that want to have control over whether DISTINCT or * should be treated 
differently. For normal UDAFs, they should still inherite from 
GenericUDAFResolver.

Does that sound OK?



> count distinct on multiple columns does not work
> ------------------------------------------------
>
>                 Key: HIVE-287
>                 URL: https://issues.apache.org/jira/browse/HIVE-287
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Arvind Prabhakar
>         Attachments: HIVE-287-1.patch, HIVE-287-2.patch, HIVE-287-3.patch, 
> HIVE-287-4.patch, HIVE-287-5-branch-0.6.patch, HIVE-287-5-trunk.patch
>
>
> The following query does not work:
> select count(distinct col1, col2) from Tbl

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to