[ 
https://issues.apache.org/jira/browse/HIVE-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892388#action_12892388
 ] 

Ning Zhang commented on HIVE-1488:
----------------------------------

It should be removed. The corresponding code in shims 0.20 was removed by 
fixing HIVE-1317, but we didn't realized the same code was in 0.19. 


> CombineHiveInputFormat for hadoop-19 is broken
> ----------------------------------------------
>
>                 Key: HIVE-1488
>                 URL: https://issues.apache.org/jira/browse/HIVE-1488
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Joydeep Sen Sarma
>
> I don't if anyone is using it. After making some recent testing related 
> changes in HIVE-1408, combine[12].q are no longer working when testing 
> against 19. I have seen them fail earlier as well and not investigated. 
> Looking at the code, it seems pretty hokey:
> getInputPathsShim():
>       Path[] newPaths = new Path[paths.length];
>       // remove file:                                                         
>                                                                               
>    
>       for (int pos = 0; pos < paths.length; pos++) {
>         newPaths[pos] = new Path(paths[pos].toString().substring(5));
>       }
> since we are no longer using 'file:' namespace for test warehouse, this is 
> broke. But this would be broken against any hdfs instance it would seem(?). 
> Also not clear what we are trying to do here.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to