[
https://issues.apache.org/jira/browse/HIVE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892594#action_12892594
]
John Sichi commented on HIVE-417:
---------------------------------
First pass of review comments on latest patch (I'll probably have more
tomorrow).
* INDEX_NAME precision in the metastore should be 128 characters (not 767),
following convention for other identifiers
* I don't think we need INDEX_TABLE_NAME at all in the metastore; it should
only be used during CREATE INDEX and then forgotten
* Move HiveIndexInputFormat and HiveIndexResult to package
org.apache.hadoop.hive.ql.index.compact, and add Compact in their names (I'd
still prefer to move this entire package out to a new subproj, but I guess we
can skip that part now since most of the code went away with the virtual column
approach); rename property hive.exec.index_file to hive.index.compact.file
* Support WITH DEFERRED REBUILD, and require this to be specified for now to
avoid confusion (per discussion in design meeting)
* when generating reentrant INSERT, need to quote identifiers such as
table/column names (use HiveUtils.unparseIdentifier), and may need extra
escaping for special characters in getPartKVPairStringArray (I'm not
sure--check with Paul)
* thread_local should be private (and named threadLocal); go through public
IOContext.get() instead; likewise use public getter/setter methods on IOContext
instead of accessing its data members directly
* need ORDER BY in virtual_column.q
* remove extra semicolon in other ORDER BY's, and make sure they cover a unique
key in all cases
* don't need TYPE and UPDATE as keywords in grammar
> Implement Indexing in Hive
> --------------------------
>
> Key: HIVE-417
> URL: https://issues.apache.org/jira/browse/HIVE-417
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Metastore, Query Processor
> Affects Versions: 0.3.0, 0.3.1, 0.4.0, 0.6.0
> Reporter: Prasad Chakka
> Assignee: He Yongqiang
> Attachments: hive-417.proto.patch, hive-417－2009-07-18.patch,
> hive-indexing-8-thrift-metastore-remodel.patch, hive-indexing.3.patch,
> hive-indexing.5.thrift.patch, hive.indexing.11.patch, idx2.png,
> indexing_with_ql_rewrites_trunk_953221.patch
>
>
> Implement indexing on Hive so that lookup and range queries are efficient.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
