[ 
https://issues.apache.org/jira/browse/HIVE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893522#action_12893522
 ] 

John Sichi commented on HIVE-417:
---------------------------------

Since another patch is needed, here are the review comments I mentioned above.

* Javadoc for Hive.createIndex needs parameters fixed

* Javadoc for HiveIndexHandler.analyzeIndexDefinition:  remove storageDesc]

* In HiveUtils.getIndexHandler:  the message should be "Error in loading index 
handler" rather than "Error in loading storage handler"

* GenericUDAFCollectSet @Description :  "with no duplication elements" should 
be "with duplicate elements eliminated"

* DDLSemanticAnalyzer.analyzeCreateIndex:  hanlder is misspelled

* Property AbstractIndexHandler.INDEX_COLS_KEY is never used; get rid of it?

* For HiveIndex.INDEX_TABLE_CREATETIME property name, spell out 
"lastModifiedTime" instead of "lmt"


> Implement Indexing in Hive
> --------------------------
>
>                 Key: HIVE-417
>                 URL: https://issues.apache.org/jira/browse/HIVE-417
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Metastore, Query Processor
>    Affects Versions: 0.3.0, 0.3.1, 0.4.0, 0.6.0
>            Reporter: Prasad Chakka
>            Assignee: He Yongqiang
>             Fix For: 0.7.0
>
>         Attachments: hive-417.proto.patch, hive-417-2009-07-18.patch, 
> hive-indexing-8-thrift-metastore-remodel.patch, hive-indexing.3.patch, 
> hive-indexing.5.thrift.patch, hive.indexing.11.patch, hive.indexing.12.patch, 
> idx2.png, indexing_with_ql_rewrites_trunk_953221.patch
>
>
> Implement indexing on Hive so that lookup and range queries are efficient.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to