[
https://issues.apache.org/jira/browse/HIVE-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897521#action_12897521
]
John Sichi commented on HIVE-1495:
----------------------------------
Oops, actually, the interface method should be declaring the new parameters as
Set<> rather than HashSet<>.
Also, for the Javadoc, we should make it clear that the handler implementation
is supposed to add information to these sets as a side effect of the call (i.e.
they are supplemental outputs going along with the return value).
While we're at it:
* move the new parameters to be last in the method signature (and Javadoc) to
distinguish them from the read-only parameters
* can we get rid of the db parameter altogether? the only thing it is used for
in CompactIndexHandler is to get the configuration, and we already have that
from setConf
Sorry for not noticing these earlier; could you give me one more patch?
> supply correct information to hooks and lineage for index rebuild
> -----------------------------------------------------------------
>
> Key: HIVE-1495
> URL: https://issues.apache.org/jira/browse/HIVE-1495
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Indexing
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: He Yongqiang
> Fix For: 0.7.0
>
> Attachments: hive-1495.1.patch, hive-1495.2.patch, hive-1495.3.patch
>
>
> This is a followup for HIVE-417.
> Ashish can probably help on how this should work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
