> On 2010-08-11 06:57:04, namit jain wrote: > > metastore/if/hive_metastore.thrift, line 35 > > <http://review.cloudera.org/r/508/diff/2/?file=5171#file5171line35> > > > > Same as John's earlier comment - do we need > > to change the name. > > > > No-one is using this table in the metastore currently, > > so it might be OK - but not sure, how JDO would > > handle renaming a column
Done. > On 2010-08-11 06:57:04, namit jain wrote: > > ql/src/test/queries/clientpositive/database.q, line 15 > > <http://review.cloudera.org/r/508/diff/2/?file=5216#file5216line15> > > > > also add a test for 'show databases for a pattern' Done. - Carl ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/508/#review838 ----------------------------------------------------------- On 2010-08-16 13:00:54, Carl Steinbach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/508/ > ----------------------------------------------------------- > > (Updated 2010-08-16 13:00:54) > > > Review request for Hive Developers. > > > Summary > ------- > > Database/Scheme support for Hive. > > * Implemented 'SHOW DATABASES' command > * Refactored TestHiveMetaStore and enabled tests for remote metastore client. > * Added launch configurations for TestHiveMetaStore and > TestHiveMetaStoreRemote > > > This addresses bug HIVE-675. > http://issues.apache.org/jira/browse/HIVE-675 > > > Diffs > ----- > > .gitignore 376cdc6 > build-common.xml d4ff895 > eclipse-templates/TestCliDriver.launchtemplate c304161 > eclipse-templates/TestEmbeddedHiveMetaStore.launchtemplate PRE-CREATION > eclipse-templates/TestHive.launchtemplate 24efc12 > eclipse-templates/TestHiveMetaStoreChecker.launchtemplate PRE-CREATION > eclipse-templates/TestRemoteHiveMetaStore.launchtemplate PRE-CREATION > metastore/if/hive_metastore.thrift 478d0af > metastore/src/gen-cpp/ThriftHiveMetastore.h e2538fb > metastore/src/gen-cpp/ThriftHiveMetastore.cpp f945a3a > metastore/src/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp ed2bb99 > metastore/src/gen-cpp/hive_metastore_types.h 1b0c706 > metastore/src/gen-cpp/hive_metastore_types.cpp b5a403d > > metastore/src/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java > 78c78d9 > > metastore/src/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java > 25408d9 > metastore/src/gen-php/ThriftHiveMetastore.php ea4add5 > metastore/src/gen-php/hive_metastore_types.php 61872a0 > metastore/src/gen-py/hive_metastore/ThriftHiveMetastore-remote fc06cba > metastore/src/gen-py/hive_metastore/ThriftHiveMetastore.py 4a0bc67 > metastore/src/gen-py/hive_metastore/ttypes.py ea7269e > metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 39dbd52 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 4fb296a > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > c6541af > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 6013644 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > 0818689 > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > a06384c > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 4951bd6 > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 4488f94 > metastore/src/model/org/apache/hadoop/hive/metastore/model/MDatabase.java > b3e098d > metastore/src/model/package.jdo 206ba75 > > metastore/src/test/org/apache/hadoop/hive/metastore/TestEmbeddedHiveMetaStore.java > PRE-CREATION > metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > fff6aad > > metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreRemote.java > bc950b9 > > metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java ef1da6b > ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java d59f48c > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java e0761fc > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 3300e2a > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java > eedf9e3 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 1801c10 > ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g b080780 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 682a8b5 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java > 6af3b17 > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateDatabaseDesc.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java ed4ed22 > ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/ShowDatabasesDesc.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/SwitchDatabaseDesc.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java b4651a2 > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java ab39ca4 > > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java > 26cc71a > ql/src/test/queries/clientnegative/database_create_already_exists.q > PRE-CREATION > ql/src/test/queries/clientnegative/database_create_invalid_name.q > PRE-CREATION > ql/src/test/queries/clientnegative/database_drop_does_not_exist.q > PRE-CREATION > ql/src/test/queries/clientnegative/database_drop_not_empty.q PRE-CREATION > ql/src/test/queries/clientnegative/database_switch_does_not_exist.q > PRE-CREATION > ql/src/test/queries/clientpositive/add_part_exist.q 54d0096 > ql/src/test/queries/clientpositive/alter1.q 6f95685 > ql/src/test/queries/clientpositive/alter2.q 2388e21 > ql/src/test/queries/clientpositive/alter3.q d9d3b07 > ql/src/test/queries/clientpositive/alter4.q 35fa441 > ql/src/test/queries/clientpositive/database.q PRE-CREATION > ql/src/test/queries/clientpositive/rename_column.q ce82ff7 > ql/src/test/results/clientnegative/database_already_exists.q.out > PRE-CREATION > ql/src/test/results/clientnegative/database_create_already_exists.q.out > PRE-CREATION > ql/src/test/results/clientnegative/database_create_invalid_name.q.out > PRE-CREATION > ql/src/test/results/clientnegative/database_drop_does_not_exist.q.out > PRE-CREATION > ql/src/test/results/clientnegative/database_drop_not_empty.q.out > PRE-CREATION > ql/src/test/results/clientnegative/database_switch_does_not_exist.q.out > PRE-CREATION > ql/src/test/results/clientpositive/add_part_exist.q.out 4bcdf8a > ql/src/test/results/clientpositive/alter1.q.out ea143a6 > ql/src/test/results/clientpositive/alter2.q.out 6de5f19 > ql/src/test/results/clientpositive/alter3.q.out 2a1f4d5 > ql/src/test/results/clientpositive/alter4.q.out da7cd9a > ql/src/test/results/clientpositive/database.q.out PRE-CREATION > ql/src/test/results/clientpositive/rename_column.q.out 8d5da8d > > Diff: http://review.cloudera.org/r/508/diff > > > Testing > ------- > > > Thanks, > > Carl > >
