[ 
https://issues.apache.org/jira/browse/HIVE-741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated HIVE-741:
-----------------------------------------

    Attachment: patch-741-1.txt
                smbjoin_nulls.q.txt

Attaching patch that fixes the bugs in earlier patch, that Ning has found. Also 
adds more testcases.

bq. Can you also add one or few tests for sort merge join? 
Attached file smbjoin_nulls.q.txt has tests for sort merge join. But it fails 
with NPE as mentioned as earlier. I tried to fix the NPE, but could not come up 
with a fix. Shall I do it on followup jira?

bq. For inner, left and right outer joins, a simpler fix would be to add a 
filter on top.
I think this can be done as part of HIVE-1544 as an improvement.

bq. @Amareshwari, sorry the syntax was wrong for the 3 table joins. 
Ning, Hive was not complaining about the syntax. So, included this also in the 
testcase. The results are fine with the latest patch.


> NULL is not handled correctly in join
> -------------------------------------
>
>                 Key: HIVE-741
>                 URL: https://issues.apache.org/jira/browse/HIVE-741
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: Ning Zhang
>            Assignee: Amareshwari Sriramadasu
>         Attachments: patch-741-1.txt, patch-741.txt, smbjoin_nulls.q.txt
>
>
> With the following data in table input4_cb:
> Key        Value
> ------       --------
> NULL     325
> 18          NULL
> The following query:
> {code}
> select * from input4_cb a join input4_cb b on a.key = b.value;
> {code}
> returns the following result:
> NULL    325    18   NULL
> The correct result should be empty set.
> When 'null' is replaced by '' it works.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to