[ 
https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904397#action_12904397
 ] 

HBase Review Board commented on HIVE-1546:
------------------------------------------

Message from: "Carl Steinbach" <c...@cloudera.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/713/
-----------------------------------------------------------

(Updated 2010-08-30 15:42:15.768310)


Review request for Hive Developers.


Changes
-------

Updated diff with 
https://issues.apache.org/jira/secure/attachment/12453466/hive-1546-3.patch


Summary
-------

review by JVS


This addresses bug HIVE-1546.
    http://issues.apache.org/jira/browse/HIVE-1546


Diffs (updated)
-----

  trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 990934 
  trunk/conf/hive-default.xml 990934 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 990934 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java 990934 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
990934 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
990934 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java 
990934 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 990934 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveSemanticAnalyzerFactory.java
 PRE-CREATION 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
990934 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 
990934 
  
trunk/ql/src/test/org/apache/hadoop/hive/ql/metadata/DummySemanticAnalyzerFactory.java
 PRE-CREATION 
  
trunk/ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSemanticAnalyzerLoading.java
 PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/genericFileFormat.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/inoutdriver.q PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/genericFileFormat.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/inoutdriver.q.out PRE-CREATION 

Diff: http://review.cloudera.org/r/713/diff


Testing
-------


Thanks,

John




> Ability to plug custom Semantic Analyzers for Hive Grammar
> ----------------------------------------------------------
>
>                 Key: HIVE-1546
>                 URL: https://issues.apache.org/jira/browse/HIVE-1546
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 0.7.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.7.0
>
>         Attachments: hive-1546-3.patch, hive-1546.patch, hive-1546_2.patch
>
>
> It will be useful if Semantic Analysis phase is made pluggable such that 
> other projects can do custom analysis of hive queries before doing metastore 
> operations on them. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to