----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/860/#review1251 -----------------------------------------------------------
Ship it! +1 Looks good to me. build.properties <http://review.cloudera.org/r/860/#comment4223> If this is the convention going forward then it's probably more appropriate to rename the old style as "oldstyle-name" instead of introducing a "newstyle-name". - Carl On 2010-09-16 15:35:00, Todd Lipcon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/860/ > ----------------------------------------------------------- > > (Updated 2010-09-16 15:35:00) > > > Review request for Hive Developers and John Sichi. > > > Summary > ------- > > Adds a shim layer for secure Hadoop, currently pulling a secure CDH3b3 > prerelease snapshot > > > This addresses bug HIVE-1264. > http://issues.apache.org/jira/browse/HIVE-1264 > > > Diffs > ----- > > build-common.xml 0b76688 > build.properties 3e392f7 > build.xml 4b345b5 > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d2c7123 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java b2966de > shims/build.xml b339871 > shims/ivy.xml de56e4f > shims/src/0.17/java/org/apache/hadoop/hive/shims/Hadoop17Shims.java 17110ab > shims/src/0.18/java/org/apache/hadoop/hive/shims/Hadoop18Shims.java 9cc8d56 > shims/src/0.19/java/org/apache/hadoop/hive/shims/Hadoop19Shims.java c643108 > shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 0675a79 > shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java > PRE-CREATION > shims/src/0.20S/java/org/apache/hadoop/hive/shims/Jetty20SShims.java > PRE-CREATION > shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java 4310942 > shims/src/common/java/org/apache/hadoop/hive/shims/ShimLoader.java c847d69 > > Diff: http://review.cloudera.org/r/860/diff > > > Testing > ------- > > Able to run MR jobs on our secure cluster with standalone (ie no separate > metastore, etc) > > > Thanks, > > Todd > >