[
https://issues.apache.org/jira/browse/HIVE-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910851#action_12910851
]
HBase Review Board commented on HIVE-1361:
------------------------------------------
Message from: "namit jain" <nj...@facebook.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/862/#review1264
-----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java
<http://review.cloudera.org/r/862/#comment4293>
This code seems useless
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java
<http://review.cloudera.org/r/862/#comment4296>
How are you accounting for speculative
execution ?
Can 2 tasks insert the entry ?
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java
<http://review.cloudera.org/r/862/#comment4305>
It might be a good idea to make it easy
to add new stats. Right now, you will need
to fix code in multiple places.
Instead of hard-coding nRowsInTable, it
would be good to keep an array of stats
we are publishing in a central place
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java
<http://review.cloudera.org/r/862/#comment4306>
This (addOutputs()) should be done at
compile time
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java
<http://review.cloudera.org/r/862/#comment4310>
Most of these parameters need not be
instance variables - have a new function
where these are defined
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java
<http://review.cloudera.org/r/862/#comment4307>
Can you add publishStats in Utilities and
let TableScan and FileSink share it
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<http://review.cloudera.org/r/862/#comment4309>
I am assuming these red blocks mean TABs
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java
<http://review.cloudera.org/r/862/#comment4311>
??
trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java
<http://review.cloudera.org/r/862/#comment4314>
Do we need to lock the row ?
use a SELECT FOR UPDATE instead of
SELECT
- namit
> table/partition level statistics
> --------------------------------
>
> Key: HIVE-1361
> URL: https://issues.apache.org/jira/browse/HIVE-1361
> Project: Hadoop Hive
> Issue Type: Sub-task
> Components: Query Processor
> Reporter: Ning Zhang
> Assignee: Ahmed M Aly
> Fix For: 0.7.0
>
> Attachments: HIVE-1361.java_only.patch, HIVE-1361.patch, stats0.patch
>
>
> At the first step, we gather table-level stats for non-partitioned table and
> partition-level stats for partitioned table. Future work could extend the
> table level stats to partitioned table as well.
> There are 3 major milestones in this subtask:
> 1) extend the insert statement to gather table/partition level stats
> on-the-fly.
> 2) extend metastore API to support storing and retrieving stats for a
> particular table/partition.
> 3) add an ANALYZE TABLE [PARTITION] statement in Hive QL to gather stats for
> existing tables/partitions.
> The proposed stats are:
> Partition-level stats:
> - number of rows
> - total size in bytes
> - number of files
> - max, min, average row sizes
> - max, min, average file sizes
> Table-level stats in addition to partition level stats:
> - number of partitions
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
