[
https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913164#action_12913164
]
HBase Review Board commented on HIVE-1378:
------------------------------------------
Message from: "Steven Wong" <skwsl...@gmail.com>
bq. On 2010-09-20 18:14:21, Zheng Shao wrote:
bq. >
Thanks for taking the time to review it! See my comments below.
bq. On 2010-09-20 18:14:21, Zheng Shao wrote:
bq. > trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java,
line 179
bq. > <http://review.cloudera.org/r/828/diff/3/?file=12162#file12162line179>
bq. >
bq. > While this function works for most cases, there is no guarantee that
it will work for nested map/array/struct, because toString() is not required to
be implemented correctly for Objects in hive.
bq. >
bq. > The preferred way would be to use
ObjectInspectorUtils/ObjectInspectorConvertors to copy/convert <Object,
ObjectInspector> to "Standard Object", and then convert to JDBC objects.
bq. >
It is a good point regarding toString. I didn't try nested container types; I'm
trying nested map for the first time now and it doesn't work. Will fix. Will
see how ObjectInspector* can help.
bq. On 2010-09-20 18:14:21, Zheng Shao wrote:
bq. >
trunk/serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java,
line 54
bq. > <http://review.cloudera.org/r/828/diff/3/?file=12173#file12173line54>
bq. >
bq. > Can we change the name to serializeField (here and in
LazySimpleSerDe)?
bq. >
OK.
- Steven
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/828/#review1273
-----------------------------------------------------------
> Return value for map, array, and struct needs to return a string
> -----------------------------------------------------------------
>
> Key: HIVE-1378
> URL: https://issues.apache.org/jira/browse/HIVE-1378
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Drivers
> Reporter: Jerome Boulon
> Assignee: Steven Wong
> Fix For: 0.7.0
>
> Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.patch
>
>
> In order to be able to select/display any data from JDBC Hive driver, return
> value for map, array, and struct needs to return a string
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
