[ 
https://issues.apache.org/jira/browse/HIVE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915942#action_12915942
 ] 

He Yongqiang commented on HIVE-1624:
------------------------------------

Mostly look good. 

In your testcase, can you put the new script file in
new Path(System.getProperty("test.data.dir", ".") + "file name") ?

By move fetchFilesNotInLocalFilesystem to SessionState, you can keep 
getScriptProgName() ect in SemanticAnalyer by changing 
fetchFilesNotInLocalFilesystem's arguments to pass in the command etc. I am 
also ok with current way.

> Patch to allows scripts in S3 location
> --------------------------------------
>
>                 Key: HIVE-1624
>                 URL: https://issues.apache.org/jira/browse/HIVE-1624
>             Project: Hadoop Hive
>          Issue Type: New Feature
>            Reporter: Vaibhav Aggarwal
>            Assignee: Vaibhav Aggarwal
>         Attachments: HIVE-1624-2.patch, HIVE-1624-3.patch, HIVE-1624-4.patch, 
> HIVE-1624.patch
>
>
> I want to submit a patch which allows user to run scripts located in S3.
> This patch enables Hive to download the hive scripts located in S3 buckets 
> and execute them. This saves users the effort of copying scripts to HDFS 
> before executing them.
> Thanks
> Vaibhav

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to