----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/795/ -----------------------------------------------------------
(Updated 2010-09-28 22:27:00.514119) Review request for Hive Developers. Changes ------- Updated diff with suggested changes. Summary ------- Adds Union type to Standard ObjectInSpectors, TypeInfo and Lazy ObjectInspectors. This addresses bug HIVE-537. http://issues.apache.org/jira/browse/HIVE-537 Diffs (updated) ----- trunk/data/files/union_input.txt PRE-CREATION trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1002189 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 1002189 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1002189 trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUnion.java PRE-CREATION trunk/ql/src/test/queries/clientpositive/create_union_table.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/udf_union.q PRE-CREATION trunk/ql/src/test/results/clientpositive/create_union_table.q.out PRE-CREATION trunk/ql/src/test/results/clientpositive/show_functions.q.out 1002189 trunk/ql/src/test/results/clientpositive/udf_union.q.out PRE-CREATION trunk/serde/src/gen-java/org/apache/hadoop/hive/serde/Constants.java 1002189 trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 1002189 trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 1002189 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java 1002189 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 1002189 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUnion.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java 1002189 trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyUnionObjectInspector.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspector.java 1002189 trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java 1002189 trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 1002189 trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardUnionObjectInspector.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionObject.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionObjectInspector.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java 1002189 trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java 1002189 trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 1002189 trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/UnionTypeInfo.java PRE-CREATION trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyArrayMapStruct.java 1002189 trunk/serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java 1002189 Diff: http://review.cloudera.org/r/795/diff Testing ------- Thanks, Amareshwari