Good eyes. Now that we're no longer using JavaCC (which was needed
for SDL), I was able to turn back on a bunch of warnings and just
checked in some cleanups of this and elsewhere. Less is more!
On Thu, 19 Aug 2004 15:49:33 +0200, Wannheden, Knut
<[EMAIL PROTECTED]> wrote:
> Few comments and questions...
>
> > + public boolean containsService(Class serviceInterface)
> > + {
> > + boolean contains = false;
> > +
> > + List servicePoints = (List)
> > _servicePointsByInterface.get(serviceInterface);
> > +
> > + return size(servicePoints) == 1;
> > + }
> > +
>
> The "contains" boolean is not really needed I suppose. And shouldn't this
> method perform a checkShutdown() also?
>
> > + public boolean containsService(String serviceId, Class
> > serviceInterface)
> > + {
> > + checkShutdown();
> > +
> > + boolean contains = false;
> > +
> > + ServicePoint point = (ServicePoint)
> > _servicePoints.get(serviceId);
> > +
> > + if (point == null)
> > + return false;
> > +
> > + return
> > point.getServiceInterface().equals(serviceInterface);
> > + }
> > +
>
> "contains" isn't used here either...
>
> --knut
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
--
Howard M. Lewis Ship
Independent J2EE / Open-Source Java Consultant
Creator, Jakarta Tapestry
Creator, Jakarta HiveMind
http://howardlewisship.com
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
