I agree. I wouldn't mix those concerns.
Take a look here (http://wiki.apache.org/jakarta-hivemind/JmxPreview) for a screenshot that shows the way a jmx management console can display
the aggregated statistical data. It is even possible to display the
duration over time as graph.
And moreover using jmx monitors you can get notified if a critical value is exceeded.
The population via jmx should be only one option so I will have a look at my code to see how easy it is to plugin different statistic services.
Achim
Jean-Francois Poilpret wrote:
Except if we consider the benefits of separating concerns. The question is: is logging concern equivalent to performance measurement concern? Personally, I really prefer to have 2 different interceptors for this. In particular, I would probably want to check performance _without_ logging enabled (since logging would degrade the real performance).
I already thought about writing such an interceptor, but I am not sure it is as easy as it sounds: I don't think it would be a good idea to just store somewhere the duration of ONE call to a method. It is generally better to have some kind of "statistics" (like: number of calls, average duration, min and max duration), and for this you need some additional configuration for your interceptor (in addition to where you want the information logged).
Or maybe a better solution would be to have a simple interceptor that calls a "statistics" service at the end of each method call, passing it the method signature, the service-point, and the exec duration. Then it is up to the statistics service to do whatever it wants with that, from the simplest to the most complex. We could then provide "minimal" implementations for such a service.
Cheers
Jean-Francois
-----Original Message-----
From: James Carman [mailto:[EMAIL PROTECTED] Sent: Tuesday, March 01, 2005 8:13 PM
To: [email protected]
Subject: RE: Timing interceptor?
It still couldn't hurt to add this to the logging interceptor.
-----Original Message-----
From: Achim Huegen [mailto:[EMAIL PROTECTED] Sent: Tuesday, March 01, 2005 8:10 AM
To: [email protected]
Subject: Re: Timing interceptor?
I've included a performance interceptor in my hivemind jmx code. It measures
duration of service calls and provides the results (min, max, avg etc.) via jmx.
The code will be available during the next days as jira patch.
Achim Huegen
David J. M. Karlsen wrote:
Would it be interesting to create an interceptor that gives timing information? (Time to enter and leave a method).
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
