Cool. Will look at it. Thanks for your help James.

------------------------------------------------------------------------
*Laurent (Harry) Hasson*
Co-Founder, 360Fresh.com <https://360Fresh.com>

This email and any attachments thereto may contain private, confidential, and privileged material for the sole use of the intended recipient. Any review, copying, or distribution of this email (or any attachments thereto) by others is strictly prohibited. If you are not the intended recipient, please contact the sender immediately and permanently delete the original and any copies of this email and any attachments thereto.

On 11/8/2012 18:14, James Agnew wrote:
Hi Laurent,

I think at this point it's safe to say the problem is solved. If you wanted to check it out for yourself, Christian committed the spiffy new ID generators here: https://hl7api.svn.sourceforge.net/svnroot/hl7api/trunk/hapi-mvn/hapi-base/src/main/java/ca/uhn/hl7v2/util/idgenerator/ . FileBasedHiLoGenerator is the default, and it is effectively doing a batch-cache as you suggest.

The next version will probably be numbered 2.1, but it is certainly at least a few months away. A number of under-the-hood cleanups have been made, and they will require a fair bit of testing before we trust them enough to release them publicly. Naturally, you can always build from source if you wanted to check it out early.

Cheers,
James



On Thu, Nov 8, 2012 at 4:20 PM, LDH <l...@360fresh.com <mailto:l...@360fresh.com>> wrote:

    This is good to know. By "next release", do you mean 3.0, or a
    2.1? When do you think that would be?

    I have had similar issues on a project many years ago. The
    solution we found which worked well in practice was to batch-cache
    IDs. I am not sure how the IDs for the ACKs are generated though
    so this may not apply.

    If the problem has been solved (and soon to be in the code), then
    great. Otherwise, i would love to have a discussion with whomever
    to see if this would work well.


    ------------------------------------------------------------------------
    *Laurent (Harry) Hasson*
    Co-Founder, 360Fresh.com <https://360Fresh.com>

    This email and any attachments thereto may contain private,
    confidential, and privileged material for the sole use of the
    intended recipient. Any review, copying, or distribution of this
    email (or any attachments thereto) by others is strictly
    prohibited. If you are not the intended recipient, please contact
    the sender immediately and permanently delete the original and any
    copies of this email and any attachments thereto.

    On 11/8/2012 13:07, James Agnew wrote:
    Hi Laurent,

    The main reason for this is that this method assigns a new
    sequential ID to each ACK message it generates, and it uses a
    file to keep track of that sequence. That file is read and
    written on each message, so it is a bit slower than you might think.

    The next release of HAPI has a great new implementation of this,
    oddly enough. Christian Ohr has written a pluggable ID generator
    module, which can use "hi-lo" files which are only occasionally
    read, as well as memory only and GUID type implementations which
    are faster still. Unfortunately that release is not yet out, and
    probably won't be for at least a few months.

    Cheers,
    James


    On Thu, Nov 8, 2012 at 9:52 AM, LDH <l...@360fresh.com
    <mailto:l...@360fresh.com>> wrote:


        Is there a reason why creating an ACK is so slow? I am calling
            DefaultApplication.makeACK(_Msh);
        This takes almost as long as the parsing of the full message
        coming in which seems counter intuitive.

        I am on V1.2.


--
        ------------------------------------------------------------------------
        *Laurent (Harry) Hasson*
        Co-Founder, 360Fresh.com <https://360Fresh.com>

        This email and any attachments thereto may contain private,
        confidential, and privileged material for the sole use of the
        intended recipient. Any review, copying, or distribution of
        this email (or any attachments thereto) by others is strictly
        prohibited. If you are not the intended recipient, please
        contact the sender immediately and permanently delete the
        original and any copies of this email and any attachments
        thereto.


        
------------------------------------------------------------------------------
        Everyone hates slow websites. So do we.
        Make your web apps faster with AppDynamics
        Download AppDynamics Lite for free today:
        http://p.sf.net/sfu/appdyn_d2d_nov
        _______________________________________________
        Hl7api-devel mailing list
        Hl7api-devel@lists.sourceforge.net
        <mailto:Hl7api-devel@lists.sourceforge.net>
        https://lists.sourceforge.net/lists/listinfo/hl7api-devel





------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov
_______________________________________________
Hl7api-devel mailing list
Hl7api-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/hl7api-devel

Reply via email to