James,

Thanks for that, I can confirm that this test now passes.

I also found the following dependencies on the pom are not required for
test panel builds:

<dependency>
    <groupId>org.mockito</groupId>
    <artifactId>mockito-core</artifactId>
    <version>1.8.5</version>
    <scope>test</scope>
</dependency>
<dependency>
    <groupId>org.netbeans.api</groupId>
    <artifactId>org-netbeans-swing-outline</artifactId>
    <version>RELEASE73</version>
    <classifier>sources</classifier>
    <scope>provided</scope>
</dependency>
<dependency>
    <groupId>org.slf4j</groupId>
    <artifactId>slf4j-api</artifactId>
    <version>${slf4j.version}</version>
</dependency>
<dependency>
    <groupId>org.slf4j</groupId>
    <artifactId>slf4j-log4j12</artifactId>
    <version>${slf4j.version}</version>
    <optional>true</optional>
</dependency>


-Mike

On Wed, Sep 10, 2014 at 7:39 AM, James Agnew <ja...@jamesagnew.ca> wrote:

> Hi Mike,
>
> That assert looks like it's just an old artifact that should have been
> removed. I've removed it from the repo and also applied your correction to
> the readerinputstream. With those two changes, the tests all pass for me.
> Can you give it a whirl? (and thanks for the fix!)
>
> Cheers,
> James
>
> On Mon, Sep 8, 2014 at 12:49 AM, Mike Mills <m...@themills.id.au> wrote:
>
>> Hello,
>>
>> I have just checked out hapi-testpanel and tried to compile/test.
>>
>> The test code fails to compile for
>> class ByteCapturingMinLowerLayerProtocolWrapperTest.
>>
>> It is missing the org.openide.util.io.ReaderInputStream class.
>>
>> A simple code change of line 53 from
>>
>>
>> InputStream iis = new ReaderInputStream(new StringReader(expected));
>>
>> to:
>>
>> InputStream iis = new ByteArrayInputStream(expected.getBytes());
>>
>> removes use of the offending class and the test compiles and works.
>>
>>
>> I still get a failure of this test:
>>
>> PrefsTest.testRecentFiles()
>>
>> It fails with an Assertion Error (java assertion not junit):
>>
>> java.lang.AssertionError
>> at
>> ca.uhn.hl7v2.testpanel.controller.Prefs.getRecentMessageXmlFiles(Prefs.java:391)
>> at
>> ca.uhn.hl7v2.testpanel.controller.PrefsTest.testRecentFiles(PrefsTest.java:28)
>>
>> Can anyone point me in the correct direction to fix this?
>>
>> Kind regards,
>>
>> -Mike
>>
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Want excitement?
>> Manually upgrade your production database.
>> When you want reliability, choose Perforce
>> Perforce version control. Predictably reliable.
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Hl7api-devel mailing list
>> Hl7api-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/hl7api-devel
>>
>>
>
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
Hl7api-devel mailing list
Hl7api-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/hl7api-devel

Reply via email to