Patch (untested) posted to http://developer.valvesoftware.com/wiki/SDK_Known_Issues_List#Case_changes_in_player_names_cause_chat_truncation for the bare bones sdk.
At 2006/03/28 01:42 PM, Physical Mayhem Bug wrote: >Well, so far Valve has never responded to any of the SDK bug reports, so you >shouldn't hold your breath waiting for them before releasing a fix. Better to >just release the fix and if there's an issue, we'll solve it. (Now Valve did >fix >http://developer.valvesoftware.com/wiki/SDK_Known_Issues_List#BotPutInServer_linker_failures > in the SDK, but they didn't respond specifically to the KI.) > >I'll post a fix for sdk_hud_chat.cpp shortly. > >At 2006/03/27 10:08 PM, Jorge Rodriguez wrote: >>Physical Mayhem Bug wrote: >> >>>Ok well then there's two bugs here: >>> >>>First, the chat being broken if the user's name doesn't appear in the chat >>>text. Let me poor a little marinara sauce over this code. Ah that's >>>better. And second, the bug that the case-insensitive name change doesn't >>>propogate properly. >>> >>>I reviewed all of the places that wacky string alloc is being used and don't >>>see any issue with making it case sensitive. Of course it would all be >>>better off being normal std::strings, but that's a fix for another day. :) >>> >>>I've posted patches for both issues on the KI list: >>> >>>http://developer.valvesoftware.com/wiki/SDK_Known_Issues_List#Case_changes_in_player_names_cause_chat_truncation >>> >>I would prefer that second patch to not be so public until the person >>who wrote that test case for case insensitivity steps forward and agrees >>that it's OK for mods to do that sort of thing. I'm not so worried about >>engine compatibility, because tier1 is a static library and I don't >>think they share strings between each other, but I'm more worried about >>making volatile changes to well-tested code. >> >>As for the first patch, could you add another patch for >>sdk_hud_chat.cpp? I'm sure those of us who are using the SDK build (like >>me) will thank you greatly. >> >>-- >>Jorge "Vino" Rodriguez >> >> >>_______________________________________________ >>To unsubscribe, edit your list preferences, or view the list archives, please >>visit: >>http://list.valvesoftware.com/mailman/listinfo/hlcoders > >_______________________________________________ >To unsubscribe, edit your list preferences, or view the list archives, please >visit: >http://list.valvesoftware.com/mailman/listinfo/hlcoders _______________________________________________ To unsubscribe, edit your list preferences, or view the list archives, please visit: http://list.valvesoftware.com/mailman/listinfo/hlcoders
