Ah, thanks Ignacio.
Well, at least your hack is a very readable hack! Sorry to have found a
bug. I know it's a good thing, but....
This is not a blocking bug for me... I made the change just to silence the
deprecation warning and to keep up with Rails 4:
DEPRECATION WARNING: The following options in your Title.belongs_to
:lost_dct declaration are deprecated: *:conditions*. Please use a scope
block instead. For example, the following:
has_many :spam_comments, conditions: { spam: true }, class_name:
'Comment'
should be rewritten as the following:
has_many :spam_comments, -> { where spam: true }, class_name: 'Comment'
So, no worries for the immediate future.
Tim
On Wed, Jan 29, 2014 at 2:24 PM, Ignacio Huerta <[email protected]> wrote:
> Funny thing, I had misread "2.1.0" instead of "2.0.1" from the start and
> my answer went along those lines :P.
>
> This is the bug: https://github.com/Hobo/hobo/issues/66
>
> Please say if it's urgent ;).
>
> Regards,
> Ignacio
>
> El 29/01/14 19:47, Owen Dall escribió:
> > Ah. OK.
> >
> > */
> > /*
> >
> > */
> > /*
> >
> > */
> > /*
> >
> > */-Owen/*
> >
> > */
> > /*
> >
> > *Owen Dall*
> >
> > *Vice President | Chief Technology Officer*
> >
> > *Barquin International*
> >
> > *Office: 202.296.7147 | Mobile: 410.991.0811*
> >
> > *Fax: 202.296.8903 | email:** [email protected] <mailto:
> [email protected]>*
> >
> > BI_Logo_2012_JPEG
> >
> >
> >
> > NOTICE: If you have received this message in error, please contact the
> > sender immediately and be aware that the use, copying, or dissemination
> > of this information is prohibited. This email transmission contains
> > information from Barquin International that may be considered privileged
> > or confidential and is intended solely for the named recipient.
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > On Wed, Jan 29, 2014 at 1:29 PM, Tim Griffin <[email protected]
> > <mailto:[email protected]>> wrote:
> >
> > Whoops, Owen, thanks for finding my typo "2.0.1".
> >
> > But, I've been upgrading my app to *Hobo 2.1.0*, not 2.0.1, and
> > working against:
> >
> > gem 'activerecord', '~> 4.0.2'
> > gem 'activesupport', '~> 4.0.2'
> > gem 'rake', '0.9.2.2'
> > gem 'tiny_tds'
> > gem 'activerecord-sqlserver-adapter', :git =>
> > '
> https://github.com/rails-sqlserver/activerecord-sqlserver-adapter.git',
> > :branch => 'master'
> > gem 'hobo_support', '2.1.0'
> > gem 'hobo_fields', '2.1.0'
> > gem 'pg', '0.17.1'
> > gem 'activerecord-postgresql-adapter', '~> 0.0.1'
> >
> > Tim
> >
> >
> >
> > On Wed, Jan 29, 2014 at 1:22 PM, Owen Dall <[email protected]
> > <mailto:[email protected]>> wrote:
> >
> > BTW, Hobo 2.0.1 has only been officially been tested with Rails
> > 3.x, not Rails 4.
> >
> > Hobo 2.1 (TBA) is being tested with Rails 4 by Ignacio.
> >
> >
> >
> > */
> > /*
> >
> > */
> > /*
> >
> > */
> > /*
> >
> > */-Owen/*
> >
> > */
> > /*
> >
> > *Owen Dall*
> >
> > *Vice President | Chief Technology Officer*
> >
> > *Barquin International*
> >
> > *Office: 202.296.7147 | Mobile: 410.991.0811*
> >
> > *Fax: 202.296.8903 | email:** [email protected]
> > <mailto:[email protected]>*
> >
> > BI_Logo_2012_JPEG
> >
> >
> >
> > NOTICE: If you have received this message in error, please
> > contact the sender immediately and be aware that the use,
> > copying, or dissemination of this information is prohibited.
> > This email transmission contains information from Barquin
> > International that may be considered privileged or confidential
> > and is intended solely for the named recipient.
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > On Tue, Jan 28, 2014 at 3:39 PM, Tim Griffin <[email protected]
> > <mailto:[email protected]>> wrote:
> >
> >
> > Hi all;
> >
> > In updating my app to Hobo 2.0.1, I'm having to make some
> > changes as advised by Rails 4.
> >
> > One that's tripping up Hobo 2.0.1 is converting a
> > :conditions parameter on a belongs_to to be a scope block.
> >
> > In a Title model, that means this:
> > belongs_to :condo_holding_title, :class_name => "Title",
> > :foreign_key => :condominium_holding_title, :conditions =>
> > "title_type = 'CondominiumHolding'"
> >
> > Needs to become this:
> > belongs_to :condo_holding_title, -> { where("title_type =
> > 'CondominiumHolding'") }, :class_name => "Title",
> > :foreign_key => :condominium_holding_title
> >
> > But the revised version is throwing:
> >
> >
> /Users/tgriffin/.rvm/gems/ruby-1.9.3-p374/gems/hobo_fields-2.1.0/lib/hobo_fields/model.rb:86:in
> > `belongs_to_with_field_declarations': wrong number of
> > arguments (3 for 2) (ArgumentError)
> >
> > As far as I can see, that method is declared with 3
> arguments:
> >
> > def self.belongs_to_with_field_declarations(name,
> > options={}, &block)
> >
> > Why is it expecting 2?
> >
> > Tim
> >
> > --
> > You received this message because you are subscribed to the
> > Google Groups "Hobo Users" group.
> > To unsubscribe from this group and stop receiving emails
> > from it, send an email to
> > [email protected]
> > <mailto:hobousers%[email protected]>.
> >
> > To post to this group, send email to
> > [email protected] <mailto:
> [email protected]>.
> > Visit this group at http://groups.google.com/group/hobousers
> .
> > For more options, visit
> > https://groups.google.com/groups/opt_out.
> >
> >
> > --
> > You received this message because you are subscribed to a topic
> > in the Google Groups "Hobo Users" group.
> > To unsubscribe from this topic, visit
> >
> https://groups.google.com/d/topic/hobousers/LFPHsqTg8p0/unsubscribe.
> > To unsubscribe from this group and all its topics, send an email
> > to [email protected]
> > <mailto:hobousers%[email protected]>.
> >
> > To post to this group, send email to [email protected]
> > <mailto:[email protected]>.
> > Visit this group at http://groups.google.com/group/hobousers.
> > For more options, visit https://groups.google.com/groups/opt_out
> .
> >
> >
> > --
> > You received this message because you are subscribed to the Google
> > Groups "Hobo Users" group.
> > To unsubscribe from this group and stop receiving emails from it,
> > send an email to [email protected]
> > <mailto:hobousers%[email protected]>.
> > To post to this group, send email to [email protected]
> > <mailto:[email protected]>.
> > Visit this group at http://groups.google.com/group/hobousers.
> > For more options, visit https://groups.google.com/groups/opt_out.
> >
> >
> > --
> > You received this message because you are subscribed to the Google
> > Groups "Hobo Users" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> > an email to [email protected].
> > To post to this group, send email to [email protected].
> > Visit this group at http://groups.google.com/group/hobousers.
> > For more options, visit https://groups.google.com/groups/opt_out.
>
> --
> Ignacio Huerta Arteche
> http://www.ihuerta.net
> Teléfono: 0034 645 70 77 35
> Email realizado con software libre
>
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Hobo Users" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/hobousers/LFPHsqTg8p0/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> [email protected].
> To post to this group, send email to [email protected].
> Visit this group at http://groups.google.com/group/hobousers.
> For more options, visit https://groups.google.com/groups/opt_out.
>
--
You received this message because you are subscribed to the Google Groups "Hobo
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/hobousers.
For more options, visit https://groups.google.com/groups/opt_out.
