> On 2017 M03 24, Fri 16:53:03 CEST Hartmut Kaiser wrote:
> > Alex,
> >
> > Sorry for the delay, just as a heads-up: I'll get back to you later
> today.
>
> I know it's not fancy, but could you havea look ?
Alex, I sincerely apologize for the delay. Too many things are going on at
the same time.
> find_prefix(), according to the code and to the documentation, returns
"the
> installation path of the specified module", i.e. 1 path.
> Why is there the need to tokenize that using a PATH_DELIMITER (":" here)
and
> then iterate over all tokens ? It looks to me like there is always exactly
one
> path ?
While find_prefix() may in principle return a list of directories. The
original idea was to encode there the build directory and the installation
directory of the core library. Frankly, I don't remember why the code
evolved to always return just one directory. So it might be ok to assume
it's always one. Please add an HPX_ASSERT enforcing that if you change the
code.
> Related, later on in that loop, the subdirs "/bin" and "/lib" are
hardcoded.
> Could that be changed to use the result from dll.get_directory() directly
> instead of trying to reconstruct it ?
dll.get_directory() is not supported on all platforms (Android and Mic
spring to mind). But for those platforms where it's supported we could
derive one of the directory prefixes from the name of the library (/lib).
The /bin directory would have to stay hardcoded, however.
One more remark. Historically we ended up having different directory and
file layouts on Windows compared to the other platforms.
Windows:
<base>/<BuildType>/bin/: all executables and all dlls
/bin/hpx: all plugins (dlls) which are dynamically
loaded
/lib: all libraries (libs) for the dlls
/lib/hpx: all libraries (libs) for plugin dlls
All other platforms
<base>/bin/: all executables
/lib: all libraries (.so)
/lib/hpx: all plugins libraries (.so) for
If you change the hardcoded names to something else, you'd need to adjust
the cmake scripts accordingly.
Regards Hartmut
---------------
http://boost-spirit.com
http://stellar.cct.lsu.edu
_______________________________________________
hpx-users mailing list
[email protected]
https://mail.cct.lsu.edu/mailman/listinfo/hpx-users
