We just need more tests for this. Please add some queries to the relevant TestSelfLeftJoin.txt file that work with this change. Also, it was reported and confirmed that the change to Select.java to aggregate handling has the side effect of not allowing things like SELECT ... COALESCE(col, VAL), ... GROUP BY COALESCE(col, VAL), so this needs more work too.
Fred ----- Original Message ----- From: "Marc de Hoop" <[EMAIL PROTECTED]> To: <hsqldb-developers@lists.sourceforge.net> Sent: 24 August 2005 10:47 Subject: Re: [Hsqldb-developers] hsqldb - added features like Right Join support, extract(dayofweek) and another bug-fix to the aggregates/build-in types problem Thank you Fred for looking to our code and implementing it in the newest version of hsqldb. Nevertheless, we've encountered one little problem. When using a left join, hsqldb gives an exception when NOT is used in the join condition. In the last version of the files we sent, we fixed this by changing Expression.java at line 3806 by adding || exprType == Expression.NOT. If you don't have a particular reason to not use this code, could you please add this part to Expression.java (see also attached file). We think everything else works fine. Thanks again, Huug Ouwersloot Marc de Hoop - TOPdesk >Thanks Marc and Huug, > >I have incorporated your changes for DOW and RIGHT OUTER as submitted in >the >patch. > >For SET NOT NULL I wrote a new implementation that checks the existing rows >and primary key. > >For Aggregates and CASE WHEN, I traced the problem to the original code and >fixed it (in Expression.updateAggregatingValue()). > >Have just committed the changes to the CVS hsqldb-dev module > >Fred > >----- Original Message ----- >From: "fredt" <[EMAIL PROTECTED]> >To: <hsqldb-developers@lists.sourceforge.net> >Sent: 16 August 2005 16:04 >Subject: Re: [Hsqldb-developers] hsqldb - added features like Right Join >support, extract(dayofweek) and another bug-fix to the aggregates/build-in >types problem > > >Thanks for the effort. I have done the first review of the patches: > >DOW: This looks fine. >SET NOT NULL: This has yet to check for values in existing rows. We have a >similar test for another alter command and can reuse it. >RIGHT OUTER: This looks fine. I need to check and test it further. >Aggregates and CASE WHEN: The change to Column.java is out of context, as >the Compare method is for comparison of column values of the same time. >Needs more work. > >I will review the changes further and add some tests in the next couple of >days. > >Fred > > > >----- Original Message ----- >From: "Marc de Hoop" <[EMAIL PROTECTED]> >To: <hsqldb-developers@lists.sourceforge.net> >Sent: 15 August 2005 15:14 >Subject: [Hsqldb-developers] hsqldb - added features like Right Join >support, extract(dayofweek) and another bug-fix to the aggregates/build-in >types problem > > >Hello list, > >We've made some other updates to hsqldb. We'll be posting them to the >patch tracker in a minute. >We've developed Right Join support, extracting a day of week of a >datetime field ( extract(dayofweek, <fieldname>) which returns the >values: sunday = 1, monday = 2, etc.) and a better version of our >bug-fix to aggregates / build-in types. In the files we'll post, our >previous feature (set [not] null ) is also included since we don't have >got any comment yet. >We'd appreciate it if someone would review our code. > >Yours, > >Marc de Hoop >Huug Ouwersloot >- TOPdesk > > >------------------------------------------------------- >SF.Net email is Sponsored by the Better Software Conference & EXPO >September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices >Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA >Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf >_______________________________________________ >hsqldb-developers mailing list >hsqldb-developers@lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/hsqldb-developers > > > >------------------------------------------------------- >SF.Net email is Sponsored by the Better Software Conference & EXPO >September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices >Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA >Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf >_______________________________________________ >hsqldb-developers mailing list >hsqldb-developers@lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/hsqldb-developers > > > >------------------------------------------------------- >SF.Net email is Sponsored by the Better Software Conference & EXPO >September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices >Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA >Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf >_______________________________________________ >hsqldb-developers mailing list >hsqldb-developers@lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/hsqldb-developers > > > ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ hsqldb-developers mailing list hsqldb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/hsqldb-developers ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ hsqldb-developers mailing list hsqldb-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/hsqldb-developers
