Hi Fred,

I was not very comfortable with adding that code were I added it (such deep if 
statements are never good).
Thanks for making it better.

> You can modify ParserDQL further to use NULLS LAST by default for the three 
> dialects.
Do you mean that if I submit a patch that does this you will integrate it?

Thanks,
Jean-Noel


-----Original Message-----
From: Fred Toussi [mailto:[email protected]] 
Sent: 05 December 2011 11:50
To: Developer discussion for HyperSQL Database Engine.
Subject: Re: [Hsqldb-developers] Order by which supports database defaults for 
nulls last

Hi Jean-Noel,

Thanks for sharing the patch. The default NULLS LAST is a useful enhancements.

The correct place to implement this feature is in the ParserDQL, which I have 
done and committed to SVN /base/trunk. The SQL setting for DB2 compatibility 
mode has also been added, to be used for future syntax compatibility features.

Default null ordering is controlled with a new setting, SET DATABASE SQL NULLS 
FIRST { TRUE | FALSE } and the connection property sql.nulls_first.

You can modify ParserDQL further to use NULLS LAST by default for the three 
dialects.

Fred Toussi

On Friday, December 02, 2011 8:49 AM, "Jean-Noël Rouvignac"
<[email protected]> wrote:
> Oops, I forgot to use the new Database.sqlSyntaxDb2 field in 
> SortAndSlice.java This is now included in this new patch.
>
> Thanks, Jean-Noel
>
>
> -----Original Message----- From: Jean-Noël Rouvignac Sent: 02 December
> 2011 08:40 To: '[email protected]' Subject:
> Order by which supports database defaults for nulls last
>
> Hello,
>
> Here is a patch changing the default sorting for nulls when using the 
> order by clause. The patch was generated from hsqldb-2.2.6.zip 
> available on Sourceforge.
>
> According to https://hibernate.onjira.com/browse/HHH-465 :
>
>       In different DBs, the sorting of nulls relative to other values
>       is handled differently.
>
>       PostgreSQL - Nulls are considered HIGHER than non-nulls. DB2 -
>       Higher MSSQL - Lower MySQL - Lower Oracle - Higher
>
> This patch is making sure that when using the Oracle or PostgreSQL, we 
> are using the same ordering for nulls. I also added a Boolean for
> sqlSyntaxDb2 since I had the information available. I leave it to 
> someone interested to expand on it.
>
> Please let me know if this patch is ok with you.
>
> Thanks, Jean-Noël Rouvignac
>
>
> ______________________________________________________________________
> This email has been scanned by the Symantec Email Security.cloud 
> service. For more information please visit 
> http://www.symanteccloud.com 
> ______________________________________________________________________
> ----------------------------------------------------------------------
> --------
> All the data continuously generated in your IT infrastructure contains 
> a definitive record of customers, application performance, security 
> threats, fraudulent activity, and more. Splunk takes this data and 
> makes sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-novd2d
> _______________________________________________
> hsqldb-developers mailing list [email protected]
> https://lists.sourceforge.net/lists/listinfo/hsqldb-developers
>
> Email had 1 attachment:
> + orderBySupportsDatabaseDefaultsForNullsLast v2.patch 17k 
> + (application/octet-
>   stream)

------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a 
definitive record of customers, application performance, security threats, 
fraudulent activity, and more. Splunk takes this data and makes sense of it. IT 
sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
hsqldb-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/hsqldb-developers

______________________________________________________________________
This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com 
______________________________________________________________________

______________________________________________________________________
This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com
______________________________________________________________________

------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure 
contains a definitive record of customers, application performance, 
security threats, fraudulent activity, and more. Splunk takes this 
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
hsqldb-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/hsqldb-developers

Reply via email to