According to Lachlan Andrew:
> Here is a patch (url-format.patch) to allow the format of 
> external_protocol URLs be <protocol>:<path>, rather than 
> <protcol>://<host>/<path>. It seems to work in the cases 
> I've tested, but I'm not sure how to try it on the test 
> suite, so I hope I haven't broken anything else...  Please 
> let me know if it needs more work.
> 
> The patch is relative to  3.2.0b4-20020616.  Let me know if 
> you need it against a more recent snapshot.
> 
> The HTML table for the description of the output expected 
> from the external transport was also poorly formatted in 
> this snapshot, so I've included another patch 
> (return-field-table.patch) to fix that, if it hasn't 
> already been done.  If you apply this patch, do so first.

Thanks for the patches.  I've gotten rid of the rowspans in the
table in external_protocols' description, as per your 2nd patch.

For the 1st one, I don't have time to test it myself, but I'd like
to wait for comments/testing from other developers if any is forthcoming.

To answer some of the questions you ask in the code of your patch,
the .get() after a sub seemed to be needed with some compilers, to
avoid warnings.  For whatever reason, we couldn't just assign the
result of a .sub() to another String, even though .sub() is supposed
to return a String.  The .get() gives us a (char *) from that, and
everything seems to work well that way.

On line 324 of URL.cc, you say "(should also check the slashes are
actually there...)".  I agree, the code should do this.

The way the slash count is encoded in the Dictionary entries is kludgy,
but I think there are similar kludges elsewhere in the code.  It's also
self-contained in one method of the URL class, so I don't have a problem
with it.

Without actually testing it yet, that's about all I can suggest.

-- 
Gilles R. Detillieux              E-mail: <[EMAIL PROTECTED]>
Spinal Cord Research Centre       WWW:    http://www.scrc.umanitoba.ca/
Dept. Physiology, U. of Manitoba  Winnipeg, MB  R3E 3J7  (Canada)


-------------------------------------------------------
This SF.NET email is sponsored by: AMD - Your access to the experts
on Hammer Technology! Open Source & Linux Developers, register now
for the AMD Developer Symposium. Code: EX8664
http://www.developwithamd.com/developerlab
_______________________________________________
htdig-dev mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/htdig-dev

Reply via email to