According to Gabriele Bartolini: > Ciao Gilles, > > just a quick note. A few weeks ago I posted a message regarding a patch > for ht://Dig 3.2 which enables to import cookies through a text file. Can > you please give it a look and - as usual - find the right words for the > description in the defaults.cc file? > > I wanted to post you the URL of my message on the mailing list archive, > but ... sf.net seems to be encountering some problems right now. > > Indeed, I'd love to commit the code in the CVS rep.
Hi, Gabriele. You don't need anyone's permission to commit to cvs, as long as there isn't a feature freeze in place, which there isn't for 3.2.0b4/b5. If you're confident that the patch works, then go ahead and commit it. I do see one potential memory leak in the patch, though - if result is non-zero, you just give a warning, but cookie_file has still been set to a new HtCookieInFileJar object, which doesn't get deleted. Shouldn't the delete cookie_file statement be moved outside of the innermost if clause, and past the end of the else clause? As for the description of the new attribute, I'm not really clear enough on what the attribute does to describe it adequately. I haven't even seen all your code, but just the patch. It seems the purpose of the file is to pre-load the memory-based cookie jar with some preset cookie values, but that's about the extent of my understanding. I've deliberately stayed clear of anything to do with cookies in ht://Dig, because I have absolutely no use for them, and feel overwhelmed already with the parts of ht://Dig I do understand, so please don't ask me to become an expert on every piece of code added to 3.2. If you add a description to defaults.cc yourself, doing your best to describe it, I'll gladly fix any grammatical errors or ask you about ambiguities I find in the description, but I don't want to have to document things I don't understand or use. Ditto for testing - I can't test cookie support in htdig, because I don't use them on my system. -- Gilles R. Detillieux E-mail: <[EMAIL PROTECTED]> Spinal Cord Research Centre WWW: http://www.scrc.umanitoba.ca/ Dept. Physiology, U. of Manitoba Winnipeg, MB R3E 3J7 (Canada) ------------------------------------------------------- This SF.net email is sponsored by: SlickEdit Inc. Develop an edge. The most comprehensive and flexible code editor you can use. Code faster. C/C++, C#, Java, HTML, XML, many more. FREE 30-Day Trial. www.slickedit.com/sourceforge _______________________________________________ htdig-dev mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/htdig-dev
