According to Ahmon Dancy: > Hello there. I'm having trouble w/ htdig and it has led me to some > questions: > > Are you the htdig maintainer?
I'm one of a few. See http://www.htdig.org/FAQ.html#q1.4 and 1.16. > If so, do you have an estimate on when the newer versions will become > production quality? I'm using 3.1.5 w/ security patch right now and > I'm wondering if it would be pointless to submit a patch against it. I'd consider the 3.1.6 snapshot in http://www.htdig.org/files/snapshots/ to be production quality right now. Our targetted release date for 3.1.6 is Feb. 1, but that may change based on the testing happening this week, including some possible, though not yet confirmed, HTML parser problems. > I'll discuss it here anyway: > > Regarding Connection.cc. On linux, connect() may return -1 and set > errno to: > > > EAGAIN No more free local ports or insufficient entries in > the routing cache. For PF_INET see the > net.ipv4.ip_local_port_range sysctl in ip(7) on how > to increase the number of local ports. > > This can easily occur when indexing a local server at maximum speed. > > > I added the following to int Connection::connect(int allow_EINTR) to > Connection.cc: > > > int Connection::connect(int allow_EINTR) > { > int status; > > for (;;) > { > status = ::connect(sock, (struct sockaddr *)&server, sizeof(server)); > + if (status < 0 && errno == EAGAIN) > + { > + sleep(1); > + continue; > + } > if (status < 0 && errno == EINTR && !allow_EINTR) > { > ::close(sock); > open(); > continue; > } > > > Let me know what you think. Well, I don't see this as a security patch as such, but it does seem to address a bug that had been reported in 3.1.5. Maybe Geoff would be more qualified to comment. (Hence the value of reporting such things on the mailing list.) Geoff has made some changes to the Connection.cc code already to deal with retries, but he didn't seem to address the EAGAIN error code explicitly, so maybe further changes are warranted. Thanks for your report! -- Gilles R. Detillieux E-mail: <[EMAIL PROTECTED]> Spinal Cord Research Centre WWW: http://www.scrc.umanitoba.ca/~grdetil Dept. Physiology, U. of Manitoba Phone: (204)789-3766 Winnipeg, MB R3E 3J7 (Canada) Fax: (204)789-3930 _______________________________________________ htdig-general mailing list <[EMAIL PROTECTED]> To unsubscribe, send a message to <[EMAIL PROTECTED]> with a subject of unsubscribe FAQ: http://htdig.sourceforge.net/FAQ.html
