Hi Gilles, At 11:07 02-02-07 -0600, Gilles Detillieux wrote:
>You're right! This is a bug. Thanks for the fix. This date >stuff is part of the code contributed by Mike Grommet back in >1999, and modified a fair bit by me before putting it in 3.1.6. >See http://www.htdig.org/attrs.html#startday and the last section of >http://www.htdig.org/hts_form.html for more information. > >However, as much as I appreciate your bug report and fix, I would have >been much more grateful to receive it a week or two ago, before 3.1.6 >was released, rather than a few days after release. The 3.1.6 code has >been available in pre-release snapshots for about six months, and for >the last 3 of these 6 months we've been strongly recommending that users >switch from 3.1.5 or older versions to the 3.1.6 snapshots for security >reasons, as well as for bug fixes. I find it rather disturbing that a >rather important and yet long-standing bug like this wasn't discovered >and reported by anyone during the pre-release period. This suggests to >me that a very, very small minority of htdig users even bothered to test >the pre-release snapshots, preferring to wait instead for the final, >"stable" release. Well, how is the final release supposed to become >"stable" if nobody bothers to test it and report bugs before the code >is actually released??? As for myself, I run htdig on a site with only >a tad over 500 documents, so I can't pick up timing problems like this >in htsearch during my own testing. Yes all you are saying is true! I was reluctant to test the snapshots because I tought It would be trivial to pass from 3.1.5 to 3.1.6 and the only reason I wanted to install 3.1.6 is for future security fixes who will be I suppose for that version. Everybody is happy with Ht://Dig here so we don't need (as far as I know) any new features. You know, even if I had tested with the snapshots, I'm not sure I would have see the problem. I found it because I replace the CGI on the live server and It made a mess pretty quickly (the load was over 40). The live server has around 80000 documents and it's an old machine. On the test server (with 2000 documents), I didn't saw the difference at first. The test server is a workstation so I tought it was OK to be slow! >The fact that you've found and fixed this bug, and the fact that you've >contributed code to the 3.1.6 development (the accents fuzzy algorithm), >suggests to be that you're a competant tester. We need people like you >during the pre-release period so we can nail bugs like this before final >release. The thought of having to roll out yet another 3.1.x release >to fix 3.1.6 bugs really doesn't appeal to me, but after less than a >week after 3.1.6 was released, the need for a 3.1.7 release is already >becoming apparent. I'll try to put time to test the snapshots next time. Sorry :-)! I'm glad that "my" patch made it in the new version. I also tought I needed a "good case" before bringing a performance problem. > > I had also to change the Makefile.config.in to make it compile on our old > > SGI plateform (SGI Irix 6.3 with the SGI Compiler): > > > > 265# diff -c Makefile.config.in.ORIG Makefile.config.in > > *** Makefile.config.in.ORIG Thu Jan 31 18:47:14 2002 > > --- Makefile.config.in Mon Feb 4 15:42:49 2002 > > *************** > > *** 23,29 **** > > PDF_PARSER= @PDF_PARSER@ > > SENDMAIL= @SENDMAIL@ > > > > ! DEFINES= -DDEFAULT_CONFIG_FILE=\"$(DEFAULT_CONFIG_FILE)\" > > LIBDIRS= -L../htlib -L../htcommon -L../db/dist -L/usr/lib > > INCS= -I$(top_srcdir)/htlib -I$(top_srcdir)/htcommon \ > > -I../db/dist -I../include > > --- 23,29 ---- > > PDF_PARSER= @PDF_PARSER@ > > SENDMAIL= @SENDMAIL@ > > > > ! DEFINES= @DEFS@ -DDEFAULT_CONFIG_FILE=\"$(DEFAULT_CONFIG_FILE)\" > > LIBDIRS= -L../htlib -L../htcommon -L../db/dist -L/usr/lib > > INCS= -I$(top_srcdir)/htlib -I$(top_srcdir)/htcommon \ > > -I../db/dist -I../include > > > > Without that, make stop with an error in htlib because it cannot resolve > > "alloca". The @DEFS@ just have the HAVE_CONFIG define. > >Yes, this does appear to be an omission in 3.1.x. The 3.2.x code does >make use of DEFS in individual Makefile.in files in subdirectories, so >I think 3.1.x should do likewise. > >-- >Gilles R. Detillieux E-mail: <[EMAIL PROTECTED]> >Spinal Cord Research >Centre WWW: http://www.scrc.umanitoba.ca/~grdetil >Dept. Physiology, U. of Manitoba Phone: (204)789-3766 >Winnipeg, MB R3E 3J7 (Canada) Fax: (204)789-3930 Thanks. ------- Robert Marchand t�l: 343-6111 poste 5210 DGTIC-SIT e-mail: [EMAIL PROTECTED] Universit� de Montr�al Montr�al, Canada _______________________________________________ htdig-general mailing list <[EMAIL PROTECTED]> To unsubscribe, send a message to <[EMAIL PROTECTED]> with a subject of unsubscribe FAQ: http://htdig.sourceforge.net/FAQ.html
