At 6:49 PM +0100 1/12/00, Marc Pohl wrote:
>i reviewed the sourcecode for htdig-3.2.0b1-dev-010900 this weekend 
>and discovered that there could be similar errors in 
>htword/WordType.cc because of signed char to int casts. The exactly 
>same error cannot happen because the iscntrl() is in the else branch 
>of IsStrictChar() in 3.2.

Could you also post your original patch to 3.1.4 with diff -c as 
well? I'd like to have it on the [EMAIL PROTECTED] lists because I 
think it will help some of these recent questions about indexing and 
searching foreign characters.

>My proposed patch is the following snippet, introducing two new 
>member functions to WordType, instead of calling isdigit() and 
>iscntrl() directly.

This looks fine to me. Since it's a bug-fix, unless I hear screams of 
protest, it's going in sometime tomorrow.

-Geoff


------------------------------------
To unsubscribe from the htdig3-dev mailing list, send a message to
[EMAIL PROTECTED] 
You will receive a message to confirm this. 

Reply via email to