On Sun, 19 Oct 2003, Sam Tregar wrote: > On Fri, 17 Oct 2003, Gabor Szabo wrote: > > > Current status v2.6 > > ------------------- > > There are 57 (actually 60 but the script reports 57) tests. > > Based on the report of Devel::Cover the tests provide a 67.95% code > > coverage. > > That seems pretty low. Is that meant to suggest that 33% of lines of > Perl code aren't executed during the test run? Maybe you ran the > tests without TEST_SHARED_MEMORY and TEST_FILE_CACHE set?
Yes I ran them without those flags so the actual test should cover more. I should have been more careful. I'll do that later and the adjust the original number. Besides the 67.95% is an average and Devel::Cover is declared to be alpha release. You can download the report from here: http://www.pti.co.il/download/ht-cover.tar.gz It already contains my tests so the average here is 68.3 but I think I'll create various reports and upload them so we can later see the progress. If there is :-) > > 2) use Test::More for these new tests. > > Why? That would add a new dependency for the module. I got enough > flak when I started using Test.pm! That's true and I was a bit worried about it but Test::More is already in 5.8.0 and based on a presentation of Schwern and chromatic I understand that nearly all the important modules already require it so it is quite likely that any user of H:T will already have it in older Perls as well. http://magnonel.guild.net/~schwern/talks/Test_Tutorial/Test-Tutorial.pdf But the reason to use it is that it has so much better facilities to write cleaner tests than Test had. > > 4) Change the code if necessary to make it easier (or possible) > > to test. > > I'd be surprised if this was necessary. HTML::Template presents a > nice black box and it's usually pretty easy to feed it a set of inputs > and examine the output. The part which is difficult to test is to emulate errors. That's what I meant but let's put the above on hold till I get my tests out as I also think that most likely it won't be necessary. > > > I have packaged the changes so far and it is available here: > > http://www.pti.co.il/download/HTML-Template-2.61_01.tar.gz > > Could you make this available as a patch with 'diff -Naur'? That > would make it easier to evaluate the changes at a glance. I will, but I think first I add some more tests. In any case the changes were so far: - the version number in Template.pm - added to Changes - META.yml was automatically added - MANIFEST - added the list of new files - Makefile.PL - prerequisite of Test::More - a couple of new files under t/ and tmpl/ Gabor ------------------------------------------------------- This SF.net email is sponsored by OSDN developer relations Here's your chance to show off your extensive product knowledge We want to know what you know. Tell us and you have a chance to win $100 http://www.zoomerang.com/survey.zgi?HRPT1X3RYQNC5V4MLNSV3E54 _______________________________________________ Html-template-users mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/html-template-users
