Status: New
Owner: ----

New issue 221 by mar...@minimum.se: pyflakes finds a lot of issues in html5lib (some critical like the "undefined" ones at the bottom)
http://code.google.com/p/html5lib/issues/detail?id=221

$ pyflakes .
./python3/parse.py:8: 'os' imported but unused
./python3/html5lib/utils.py:3: 'version_info' imported but unused
./python3/html5lib/__init__.py:16: 'parse' imported but unused
./python3/html5lib/__init__.py:16: 'HTMLParser' imported but unused
./python3/html5lib/__init__.py:16: 'parseFragment' imported but unused
./python3/html5lib/__init__.py:17: 'getTreeBuilder' imported but unused
./python3/html5lib/__init__.py:18: 'getTreeWalker' imported but unused
./python3/html5lib/__init__.py:19: 'serialize' imported but unused
./python3/html5lib/inputstream.py:6: 'types' imported but unused
./python3/html5lib/inputstream.py:18: redefinition of unused 'BytesIO' from line 16 ./python3/html5lib/inputstream.py:23: redefinition of unused 'BufferedIOBase' from line 21 ./python3/html5lib/inputstream.py:110: local variable 'data' is assigned to but never used
./python3/html5lib/inputstream.py:293: 'sys' imported but unused
./python3/html5lib/tokenizer.py:11: 'entitiesWindows1252' imported but unused
./python3/html5lib/tokenizer.py:12: 'asciiLowercase' imported but unused
./python3/html5lib/tokenizer.py:801: redefinition of function 'scriptDataDoubleEscapedDashState' from line 778
./python3/html5lib/html5parser.py:4: 'sys' imported but unused
./python3/html5lib/html5parser.py:17: 'formattingElements' imported but unused ./python3/html5lib/html5parser.py:18: 'tableInsertModeElements' imported but unused
./python3/html5lib/html5parser.py:19: 'voidElements' imported but unused
./python3/html5lib/html5parser.py:20: redefinition of unused 'spaceCharacters' from line 16 ./python3/html5lib/html5parser.py:91: local variable 'e' is assigned to but never used ./python3/html5lib/html5parser.py:408: local variable 'element' is assigned to but never used ./python3/html5lib/html5parser.py:1405: local variable 'name' is assigned to but never used ./python3/html5lib/html5parser.py:1591: local variable 'node' is assigned to but never used
./python3/html5lib/tests/test_tokenizer.py:5: 'sys' imported but unused
./python3/html5lib/tests/test_tokenizer.py:7: 'io' imported but unused
./python3/html5lib/tests/test_tokenizer.py:14: redefinition of unused 'json' from line 12 ./python3/html5lib/tests/test_tokenizer.py:183: local variable 'testName' is assigned to but never used ./python3/html5lib/tests/test_tokenizer.py:187: local variable 'skip' is assigned to but never used
./python3/html5lib/tests/test_encoding.py:3: 're' imported but unused
./python3/html5lib/tests/test_encoding.py:30: local variable 't' is assigned to but never used ./python3/html5lib/tests/test_encoding.py:47: local variable 'test_name' is assigned to but never used
./python3/html5lib/tests/test_encoding.py:55: 'chardet' imported but unused
./python3/html5lib/tests/test_serializer.py:10: redefinition of unused 'json' from line 8 ./python3/html5lib/tests/test_serializer.py:18: 'html5parser' imported but unused
./python3/html5lib/tests/test_sanitizer.py:3: 'os' imported but unused
./python3/html5lib/tests/test_sanitizer.py:4: 'sys' imported but unused
./python3/html5lib/tests/test_sanitizer.py:5: 'unittest' imported but unused
./python3/html5lib/tests/test_sanitizer.py:10: redefinition of unused 'json' from line 8
./python3/html5lib/tests/test_stream.py:3: 'support' imported but unused
./python3/html5lib/tests/__init__.py:12: 'support' imported but unused
./python3/html5lib/tests/test_treewalkers.py:16: 'LintError' imported but unused ./python3/html5lib/tests/test_treewalkers.py:16: 'LintFilter' imported but unused ./python3/html5lib/tests/test_treewalkers.py:20: redefinition of unused 'COMMENT' from line 117 ./python3/html5lib/tests/test_treewalkers.py:87: 'ElementTree' imported but unused ./python3/html5lib/tests/test_treewalkers.py:98: 'BeautifulSoup' imported but unused ./python3/html5lib/tests/tokenizertotree.py:10: 'test_parser' imported but unused
./python3/html5lib/tests/support.py:25: 'html5lib' imported but unused
./python3/html5lib/tests/support.py:26: 'html5parser' imported but unused
./python3/html5lib/tests/support.py:56: 'lxml' imported but unused
./python3/html5lib/tests/support.py:62: 'BeautifulSoup' imported but unused
./python3/html5lib/tests/test_parser2.py:5: 'support' imported but unused
./python3/html5lib/tests/test_parser2.py:37: local variable 'doc' is assigned to but never used
./python3/html5lib/tests/test_parser.py:6: 'io' imported but unused
./python3/html5lib/tests/test_parser.py:14: 'html5lib' imported but unused
./python3/html5lib/tests/test_parser.py:15: 'treebuilders' imported but unused ./python3/html5lib/serializer/htmlserializer.py:27: redefinition of unused 'entities' from line 14 ./python3/html5lib/serializer/htmlserializer.py:231: local variable 'attributes' is assigned to but never used ./python3/html5lib/treewalkers/genshistream.py:5: 'NamespaceFlattener' imported but unused ./python3/html5lib/treewalkers/_base.py:98: undefined name 'NodeImplementedError' ./python3/html5lib/treewalkers/_base.py:157: local variable 'endTag' is assigned to but never used
./python3/html5lib/treewalkers/etree.py:6: 'copy' imported but unused
./python3/html5lib/treewalkers/etree.py:10: 'voidElements' imported but unused ./python3/html5lib/treewalkers/etree.py:11: 'moduleFactorFactory' imported but unused ./python3/html5lib/treewalkers/etree.py:129: undefined name 'moduleFactoryFactory'
./python3/html5lib/treewalkers/dom.py:9: 'voidElements' imported but unused
./python3/html5lib/treewalkers/simpletree.py:50: undefined name '_node'
./python3/html5lib/treewalkers/lxmletree.py:8: 'sys' imported but unused
./python3/html5lib/treewalkers/lxmletree.py:13: 'voidElements' imported but unused ./python3/html5lib/treebuilders/etree.py:209: local variable 'finalText' is assigned to but never used ./python3/html5lib/treebuilders/etree.py:273: local variable 'finalText' is assigned to but never used
./python3/html5lib/treebuilders/dom.py:5: 're' imported but unused
./python3/html5lib/treebuilders/dom.py:9: 'ihatexml' imported but unused
./python3/html5lib/treebuilders/__init__.py:37: 'sys' imported but unused
./python3/html5lib/treebuilders/__init__.py:86: redefinition of unused 'ET' from line 83 ./python3/html5lib/treebuilders/__init__.py:89: redefinition of unused 'ET' from line 86 ./python3/html5lib/treebuilders/__init__.py:91: redefinition of unused 'ET' from line 89
./python3/html5lib/trie/datrie.py:3: 'chain' imported but unused
./python3/utils/spider.py:11: redefinition of unused 'urllib' from line 10
./python3/utils/spider.py:102: local variable 'KeyError' is assigned to but never used
./python3/utils/package.py:4: 'sys' imported but unused
./python/parse.py:8: 'os' imported but unused
./python/html5lib/__init__.py:15: 'parse' imported but unused
./python/html5lib/__init__.py:15: 'HTMLParser' imported but unused
./python/html5lib/__init__.py:15: 'parseFragment' imported but unused
./python/html5lib/__init__.py:16: 'getTreeBuilder' imported but unused
./python/html5lib/__init__.py:17: 'getTreeWalker' imported but unused
./python/html5lib/__init__.py:18: 'serialize' imported but unused
./python/html5lib/inputstream.py:4: 'types' imported but unused
./python/html5lib/inputstream.py:16: redefinition of unused 'BytesIO' from line 14 ./python/html5lib/inputstream.py:21: redefinition of unused 'BufferedIOBase' from line 19 ./python/html5lib/inputstream.py:114: local variable 'data' is assigned to but never used
./python/html5lib/inputstream.py:307: 'sys' imported but unused
./python/html5lib/tokenizer.py:5: 'entitiesWindows1252' imported but unused
./python/html5lib/tokenizer.py:6: 'asciiLowercase' imported but unused
./python/html5lib/tokenizer.py:830: redefinition of function 'scriptDataDoubleEscapedDashState' from line 806
./python/html5lib/html5parser.py:2: 'sys' imported but unused
./python/html5lib/html5parser.py:15: 'formattingElements' imported but unused ./python/html5lib/html5parser.py:16: 'tableInsertModeElements' imported but unused
./python/html5lib/html5parser.py:17: 'voidElements' imported but unused
./python/html5lib/html5parser.py:18: redefinition of unused 'spaceCharacters' from line 14 ./python/html5lib/html5parser.py:95: local variable 'e' is assigned to but never used ./python/html5lib/html5parser.py:427: local variable 'element' is assigned to but never used ./python/html5lib/html5parser.py:1535: local variable 'name' is assigned to but never used ./python/html5lib/html5parser.py:1730: local variable 'node' is assigned to but never used
./python/html5lib/tests/test_tokenizer.py:5: 'sys' imported but unused
./python/html5lib/tests/test_tokenizer.py:7: 'io' imported but unused
./python/html5lib/tests/test_tokenizer.py:16: redefinition of unused 'json' from line 14 ./python/html5lib/tests/test_tokenizer.py:204: local variable 'testName' is assigned to but never used ./python/html5lib/tests/test_tokenizer.py:208: local variable 'skip' is assigned to but never used
./python/html5lib/tests/test_encoding.py:2: 're' imported but unused
./python/html5lib/tests/test_encoding.py:34: local variable 't' is assigned to but never used ./python/html5lib/tests/test_encoding.py:53: local variable 'test_name' is assigned to but never used
./python/html5lib/tests/test_encoding.py:62: 'chardet' imported but unused
./python/html5lib/tests/test_serializer.py:12: redefinition of unused 'json' from line 10 ./python/html5lib/tests/test_serializer.py:20: 'html5parser' imported but unused
./python/html5lib/tests/test_sanitizer.py:2: 'os' imported but unused
./python/html5lib/tests/test_sanitizer.py:3: 'sys' imported but unused
./python/html5lib/tests/test_sanitizer.py:4: 'unittest' imported but unused
./python/html5lib/tests/test_sanitizer.py:9: redefinition of unused 'json' from line 7
./python/html5lib/tests/test_stream.py:2: 'support' imported but unused
./python/html5lib/tests/__init__.py:11: 'support' imported but unused
./python/html5lib/tests/test_treewalkers.py:16: 'LintError' imported but unused ./python/html5lib/tests/test_treewalkers.py:16: 'LintFilter' imported but unused ./python/html5lib/tests/test_treewalkers.py:20: redefinition of unused 'COMMENT' from line 118 ./python/html5lib/tests/test_treewalkers.py:88: 'ElementTree' imported but unused ./python/html5lib/tests/test_treewalkers.py:99: 'BeautifulSoup' imported but unused ./python/html5lib/tests/tokenizertotree.py:9: 'test_parser' imported but unused
./python/html5lib/tests/support.py:25: 'html5lib' imported but unused
./python/html5lib/tests/support.py:26: 'html5parser' imported but unused
./python/html5lib/tests/support.py:56: 'lxml' imported but unused
./python/html5lib/tests/support.py:62: 'BeautifulSoup' imported but unused
./python/html5lib/tests/test_parser2.py:4: 'support' imported but unused
./python/html5lib/tests/test_parser2.py:40: local variable 'doc' is assigned to but never used
./python/html5lib/tests/test_parser.py:5: 'io' imported but unused
./python/html5lib/tests/test_parser.py:13: 'html5lib' imported but unused
./python/html5lib/tests/test_parser.py:14: 'treebuilders' imported but unused ./python/html5lib/serializer/htmlserializer.py:24: redefinition of unused 'entities' from line 11 ./python/html5lib/serializer/htmlserializer.py:232: local variable 'attributes' is assigned to but never used ./python/html5lib/treewalkers/genshistream.py:4: 'NamespaceFlattener' imported but unused ./python/html5lib/treewalkers/_base.py:92: undefined name 'NodeImplementedError' ./python/html5lib/treewalkers/_base.py:157: local variable 'endTag' is assigned to but never used
./python/html5lib/treewalkers/etree.py:5: 'copy' imported but unused
./python/html5lib/treewalkers/etree.py:9: 'voidElements' imported but unused
./python/html5lib/treewalkers/etree.py:10: 'moduleFactorFactory' imported but unused ./python/html5lib/treewalkers/etree.py:133: undefined name 'moduleFactoryFactory'
./python/html5lib/treewalkers/dom.py:8: 'voidElements' imported but unused
./python/html5lib/treewalkers/simpletree.py:49: undefined name '_node'
./python/html5lib/treewalkers/lxmletree.py:11: 'voidElements' imported but unused ./python/html5lib/treewalkers/lxmletree.py:117: redefinition of function '__unicode__' from line 113 ./python/html5lib/treebuilders/etree.py:235: local variable 'finalText' is assigned to but never used ./python/html5lib/treebuilders/etree.py:284: local variable 'filter' is assigned to but never used ./python/html5lib/treebuilders/etree.py:301: local variable 'finalText' is assigned to but never used
./python/html5lib/treebuilders/dom.py:4: 're' imported but unused
./python/html5lib/treebuilders/dom.py:8: 'ihatexml' imported but unused
./python/html5lib/treebuilders/__init__.py:36: 'sys' imported but unused
./python/html5lib/treebuilders/__init__.py:85: redefinition of unused 'ET' from line 82 ./python/html5lib/treebuilders/__init__.py:88: redefinition of unused 'ET' from line 85 ./python/html5lib/treebuilders/__init__.py:90: redefinition of unused 'ET' from line 88
./python/html5lib/trie/datrie.py:2: 'chain' imported but unused
./python/utils/spider.py:11: redefinition of unused 'urllib' from line 10
./python/utils/spider.py:102: local variable 'KeyError' is assigned to but never used
./python/utils/package.py:4: 'sys' imported but unused





$ pyflakes . | grep undefined
./python3/html5lib/treewalkers/_base.py:98: undefined name 'NodeImplementedError' ./python3/html5lib/treewalkers/etree.py:129: undefined name 'moduleFactoryFactory'
./python3/html5lib/treewalkers/simpletree.py:50: undefined name '_node'
./python/html5lib/treewalkers/_base.py:92: undefined name 'NodeImplementedError' ./python/html5lib/treewalkers/etree.py:133: undefined name 'moduleFactoryFactory'
./python/html5lib/treewalkers/simpletree.py:49: undefined name '_node'


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"html5lib-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to html5lib-discuss+unsubscr...@googlegroups.com.
To post to this group, send an email to html5lib-discuss@googlegroups.com.
Visit this group at http://groups.google.com/group/html5lib-discuss?hl=en-GB.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to