On Tue, 18 Jun 2002, Smejkal Petr wrote:

> old Compiler.pm line 87:
> use Inline C => Config => OPTIMIZE => "$optimize", DIRECTORY => 
>"$self->{package_dir}" $inline_debug;
>
> new Compiler.pm line 87:
> use Inline C => Config => OPTIMIZE => '$optimize', DIRECTORY => 
>'$self->{package_dir}' $inline_debug;
>
> I'm sure you can imagine what the backslash (used in Win32 paths) will
> do inside "..."

Right.

> Do not expect that M$ Windows ships with "indent" included. :-)

Maybe I need to enable 'indent' with a separate switch.  I assumed no one
else would want to use "jit_debug" mode so it would be ok to have it
require 'indent'.  I guess I was wrong!  The problem is, without 'indent'
the generated C code will be practically unreadable.

> The join statement above is good if your C compiler doesn't handle too
> long lines. I have quite large texts without any <tmpl_*> tags in my
> templates and H:T:JIT converts these texts into one-line string. I don't
> know the exact line length limit of MS Visual C compiler but 3500 is too
> much for it :-)

Good catch.

> 4)
> JIT.pm
>   ...
>   my $filepath = $self->_find_file(...);
>   ...
>
> Please let us define our own _find_file methods in successive objects.

Explain?  _find_file() is designed to work the same way as
HTML::Template::_find_file().  This is necessary because it essentially
"predicts" the results of HTML::Template::_find_file().  If they aren't
the same then you'll end up with HTML::Template::JIT able to find a
template file but unable to use HTML::Template to parse it!

> 5) All the test are OK except "08print_to_stdout.t". You really can't do
> "unless (open(TEST, '-|')) {" on MSWin32 (ActivePerl 5.6.1 build 632)
> :-(

I imagine I'll have to just skip those tests on Win32.  To be honest, I
didn't really consider the module to be likely to work on Windows!  I'm
happy to hear that it does.  Hopefully with your help 0.04 will work
without needing modification.

-sam



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to