On Sun, 2006-08-27 at 13:14 +0200, Roland Weber wrote:
> Hi Oleg,
> 
> just a few minor observations:
> 
> EventMask: unless you're going to add more, this should either
> be an interface or have the default constructor disabled.
> 

Good point.

> IOSession: the get/set/removeAttribute methods look exactly
> like those in HttpContext. Derive the session from the context?
> 

Good point.

> No JavaDoc warnings ;-)
> 

No javadocs - no javadocs warnings ;-)

Oleg

> cheers,
>   Roland
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to