Folks,

I am currently working on WAGON-568 and would like better understand how HttpEntity#isReproducible() should be properly handled.

In AbstractHttpClientWagon#put() [1] on specific status codes the request (PUT) is retried manually with the same HttpEntity [2]
without:

* consuming the given response entity,
* calling fireTransferError() (Wagon internal),
* knowing that the entity is repeatable

This may apply if expect/continue did not work properly.

From what I understand, this approach is broken. I have either to fix the above or employ a modified version of DefaultRedirectStrategy.

Is my understanding correct?

Anyway, I have always signal an exception when a already consumed request body cannot be replayed?!

Michael

[1] https://github.com/apache/maven-wagon/blob/master/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java#L674 [2] https://github.com/apache/maven-wagon/blob/master/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java#L739-L743

---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-users-unsubscr...@hc.apache.org
For additional commands, e-mail: httpclient-users-h...@hc.apache.org

Reply via email to