Hi Julius, > One note, though: our HostnameVerifier interface *does* subclass > javax.net.ssl.HostnameVerifier, so that fact probably alleviates your > concerns somewhat as well. People can use the boolean method provided if > they really want to.
No, that actually gave rise to those concerns. If *different* interfaces use a different style, there is less concern of people mixing up the styles. Calling an exception-throwing method and checking it like a boolean will generate a compiler error. But calling a boolean-returning method and not checking it because you think it is exception-throwing will not trigger any warnings. Hence bringing those styles together in the same interface using the same name means asking for trouble. > I'll rename the methods as part of HTTPCLIENT-617 when I get around to that > patch. (Is it okay to address style concerns like this in an existing bug, > or should a new bug be created?). Thanks. I don't have a problem with addressing this in HC-617. If I felt that an extra issue was needed, I would have created one :-) cheers (and a happy new year), Roland --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
