[
https://issues.apache.org/jira/browse/HTTPCORE-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roland Weber updated HTTPCORE-39:
---------------------------------
Attachment: 2k7-02-10-status-followup.txt
Here's a new take. I definitely had to change fewer classes in NIO this time.
The required modifications to HttpClient and HttpAsync are included.
I made one minor functional modification for which I had to adapt a test case:
if there is no reason phrase, a space character will apear after the status
code anyway.
The reason is this test case which I noticed recently:
TestStatusLine.testParseSuccess:
//this is not strictly valid, but is lienent
statusLine = BasicStatusLine.parse("HTTP/1.1 200");
cheers,
Roland
> refactor HttpStatus
> -------------------
>
> Key: HTTPCORE-39
> URL: https://issues.apache.org/jira/browse/HTTPCORE-39
> Project: HttpComponents Core
> Issue Type: Improvement
> Components: HttpCore
> Affects Versions: 4.0-alpha3
> Reporter: Roland Weber
> Assigned To: Roland Weber
> Priority: Minor
> Fix For: 4.0-alpha4
>
> Attachments: 2k7-02-03-HttpStatus.txt, 2k7-02-04-status-followup.txt,
> 2k7-02-06-impl-catalog.txt, 2k7-02-10-status-followup.txt
>
>
> The HttpStatus class not only represents a status code with associated
> message, it also has static factory methods for creating objects with
> hard-coded english status messages. Suggested improvements:
> - define HttpStatusFactory in the API
> - move the factory method stuff to impl, for example EnglishHttpStatusFactory
> - reduce HttpStatus class to representation only, final and serializable
> patch to follow when I find the time
> cheers,
> Roland
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
