[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492504
 ] 

Oleg Kalnichevski commented on HTTPCLIENT-650:
----------------------------------------------

Looks good to me

Oleg

> Wire log is incomplete if HttpParser detects an error
> -----------------------------------------------------
>
>                 Key: HTTPCLIENT-650
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-650
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.1 RC1
>            Reporter: Sebb
>            Priority: Minor
>         Attachments: 2k7-04-28-wire-log.txt
>
>
> If HttpParser detects an error in any of the headers, it throws a 
> ProtocolException
> Although the failing header is included in the Exception detail, the headers 
> leading up to the failure are not logged, which makes it hard to debug (and 
> is quite confusing, as the PE does not appear to be related to the data that 
> has been received).
> This is because the wire-logging is done in the caller (HttpMethodDirector) 
> which only logs the header if the parse succeeds.
> Perhaps the Wire logging should be done at the point where the HttpParser 
> reads the line.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to