On Sun, 2007-05-13 at 18:30 +0200, Roland Weber wrote:
> Hi Oleg,
>
> > ---
> > jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/impl/client/DefaultClientRequestDirector.java
> > (original)
> > +++
> > jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/impl/client/DefaultClientRequestDirector.java
> > Sun May 13 07:46:12 2007
> > + if (port < 0) {
> > + SchemeRegistry schemeREgistry =
> > connManager.getSchemeRegistry();
> > + Scheme scheme =
> > schemeREgistry.getScheme(target.getSchemeName());
> > + port = scheme.getDefaultPort();
> > + }
>
> Just the capitalization of the variable. Is it necessary
> to have the variable at all, if there is no null check?
>
Good catch.
I tend to prefer intermediate variables to line folding, but I do not
mind it other way either. I cleaned things up a little. I hope it is all
okay now
Oleg
> cheers,
> Roland
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
