[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503847
 ] 

Oleg Kalnichevski commented on HTTPCLIENT-658:
----------------------------------------------

Olaf,
Test case looks reasonable to me. 

Folks

Any objections to committing this patch? I was always very reluctant to make 
this change because it addresses the problem caused by a clear abuse of the 
API, but given the fact API is known to be bad and the patch appears to have no 
side effects, I am in favor of accepting this patch. 

If I hear no load objections, I'll commit the patch in a few days

Oleg

> Custom Protocol in HostConfiguration ignored
> --------------------------------------------
>
>                 Key: HTTPCLIENT-658
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-658
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.1 RC1
>            Reporter: Olaf Sebelin
>             Fix For: 3.1 Final
>
>         Attachments: patch.txt, patch_TestHostConfiguration.txt
>
>
> If you you do not register a custom Protocol as scheme default handler but 
> set it in HostConfiguration, it will be ignored if the URL given to a Method 
> instance is absolute.
> HttpClient will then override it by calling hostconfig.setHost(uri).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to