[
https://issues.apache.org/jira/browse/HTTPCLIENT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515766
]
Roland Weber commented on HTTPCLIENT-669:
-----------------------------------------
Hi Andrea,
I had to made a few modifications before committing your patch. Technically,
the problem was that your additions to HttpConn were depending on HttpClient,
which is something I'd prefer to avoid.
- HttpRoutePlanner returns a route, not a routed request
- default implementation currently in client, it still depends on a constant
defined in HttpClientParams
- attribute in AbstractHttpClient is private and accessed via getter, to ensure
initialization
- added license headers
I had to remove the @author tags for now, since your CLA is not on file. I'll
put them in when your name is listed here:
http://people.apache.org/~jim/committers.html#unlistedclas
Thanks a lot for this contribution,
Roland
> introduce HttpRoutePlanner interface
> ------------------------------------
>
> Key: HTTPCLIENT-669
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-669
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient, HttpConn
> Reporter: Roland Weber
> Fix For: 4.0 Alpha 2
>
> Attachments: firstImpl.patch, secondImpl.patch
>
>
> Define an interface to determine a route for a given target host.
> Create default implementation replacing DefaultHttpClient.determineRoute(...);
> Implementations will need access to params and/or request.
> The interface fits into HttpConn, but DHC.dR(...) uses client parameters.
> Either move parameters to HttpConn, or keep default implementation in
> HttpClient.
> Alternative implementations could evaluate Java system properties related to
> proxy settings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
