[
https://issues.apache.org/jira/browse/HTTPCORE-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524337
]
Oleg Kalnichevski commented on HTTPCORE-110:
--------------------------------------------
Hi Roland
I reviewed the changed and I think this is a job well done. The only issue I
have is that lineParser and lineFormatter setters in
AbstractHttpClient/ServerConnection take no effect once the connection has been
initialized. I find this kind of nasty and think the problem needs fixing. We
should either make sure lineParser and lineFormatter get propagated to the
existing message parser and formatter when changed with the setter or replace
the setters with a factory method (requires subclassing but consistent with the
rest of the code). I tend to prefer the latter approach. We should also provide
a consistent mechanism to override lineParser and lineFormatter in the NIO
connection classes.
Oleg
PS: Do you think we need to revisit the header continuation parsing discussion?
> refactor message parsing and formatting, step 2
> -----------------------------------------------
>
> Key: HTTPCORE-110
> URL: https://issues.apache.org/jira/browse/HTTPCORE-110
> Project: HttpComponents Core
> Issue Type: Improvement
> Components: HttpCore
> Affects Versions: 4.0-alpha5
> Reporter: Roland Weber
> Assignee: Roland Weber
> Fix For: 4.0-alpha6
>
> Attachments: 2k7-08-20-parser-1.txt, 2k7-08-23-parser-2.txt
>
>
> The line-level parsing and formatting for HTTP messages is spread across
> static helper methods in o.a.h.message. Refactor the code to allow for easy
> replacement of these parser and formatter elements, which are used by both
> core and NIO.
> Ideally, handling of header continuation lines, which is currently still
> implemented in specific parsers for blocking and NIO, could be factored out
> too. That would require a stateful parser.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
