-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Porting the LRU cache from Chrome to FF is high on my to-do list, but if Nick wants to do it, he gets lots of <3's. HI NICK.
- -Yan On 01/17/2014 09:41 PM, Peter Eckersley wrote: > On Fri, Jan 17, 2014 at 05:51:13PM -0800, Jacob Hoffman-Andrews > wrote: >> >>> On the other hand, the SQLite solution should be let us scale >>> not just to ~10K rulesets but if we're lucky to more like >>> ~100K. >> >> >> This is one of the things I like about it. Also it reduces memory >> use, which is especially valuable on mobile. > > That's probably true, although for optimal performance we may hope > that the whole .sqlite file is in the OS'es page cache; it looks > like it takes up about 20MB. Perhaps on any OS where we think we > aren't RAM constrained we should just cat the file to /dev/null (or > whatever the local equivalent operation is) in the background. > > Another downside is that the .sqlite file format roughly doubles > the size of our .xpi file from ~1MB to ~2MB (in the current master > branch). I guess we can live with that. We should warn EFF's ops > team though :). > > On balance that cost seems outweighed by the startup time benefits, > so I think we should merge the pull request. > > After that I'm wondering whether we should port in Nick > Semenkovich's fancier LRU caching layer (which is the chrome > version of the extension only right now) in place of the one you > used; that has a few benefits: (1) prevents us from needing to keep > all of the targets table in RAM; (2) optimises away all the > expensive string manipulations in potentiallyApplicableRulesets; > (3) it's safe against having the negative cache bloat indefinitely > if the user never restarts their browser and meets Lots and Lots of > domains. > - -- Yan Zhu [email protected] Technologist Tel +1 415 436 9333 x134 Electronic Frontier Foundation Fax +1 415 436 9993 -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJS2iHqAAoJENC7YDZD/dnswjMIAJK5XH0WOGXcEZSwJUk/HDj6 QdCCPwF1hKVw2qRX5V6S37A/K6DJiY78fR/IWwevK0y3GBtGDf8ucypHYF1U1tu8 qsi74WGgnq2+guN4OPn92IQqqWMV4ly4aTM/JO9twqdIxTgvgzmwU4Fsl1fEk6bg Fl3Fo2R7LoGCOXiSWDJzlF35TDPbja9gwC1Xv5bNogr4q6hQdulKiEzN6qySr9fA GFgIIVvlOp8dT3ExgGW/gqRSTmfG2SDkePGWahOnQZTn9pUY6Gwcf8VAHl01WliQ Vo4Hxirljn/4iNmCplrTyef2j2/+hg+qt9Y/mJT9urydqADW+VBrIAac/36bulA= =UAHJ -----END PGP SIGNATURE----- _______________________________________________ HTTPS-Everywhere mailing list [email protected] https://lists.eff.org/mailman/listinfo/https-everywhere
