About changeset 1829ca5c3668. Comparing a minimum of red, green, and blue values with the LowerLimit (and a maximum of them with a UpperLimit) it makes a trouble. For example, a bright blue sky - rgb(0,6, 0,85, 0,99). It normally exposed but will be cut (by UpperLimit criteria) because of the blue channel "too bright". Another case: a grass in the shade - rgb(0.05, 0.2, 0.001). The same result (by LowerLimit criteria) - exposure normal, but the blue channel "too dark." As I understand, to solve this problem, LowerLimit should be compared against the maximum and UpperLimit against the minimum: if (maxVal < LowerLimit || minVal > UpperLimit) Attached patch makes this default. Also it contains quick'n'dirty hack to make (using environment variables LOWER_CUTOFF_VAL and UPPER_CUTOFF_VAL) this conditions tunable.
** Patch added: "changes (Lower|Upper)Limit condition in the applyExposureClipMask function" https://bugs.launchpad.net/hugin/+bug/1508898/+attachment/4507452/+files/vigra_ext-applyExposureClipMask.diff.gz -- You received this bug notification because you are a member of Hugin Developers, which is subscribed to Hugin. https://bugs.launchpad.net/bugs/1508898 Title: Parameterization of nona "--clip-exposure" option Status in Hugin: Fix Committed Bug description: For now nona has hardcoded dark and bright pixel levels for "--clip- exposure" option. IMHO, it could be helpful to make these levels are modifiable by the user. The patch in the attachment adds two command line options ("--dark-level" and "--bright-level") to set dark and bright pixel levels. To manage notifications about this bug go to: https://bugs.launchpad.net/hugin/+bug/1508898/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~hugin-devs Post to : [email protected] Unsubscribe : https://launchpad.net/~hugin-devs More help : https://help.launchpad.net/ListHelp
